# HG changeset patch # User Bram Moolenaar # Date 1627062305 -7200 # Node ID 92e7a55ab0ff664d14e23d996f47c9d8260b05bd # Parent cc3d1966a224a3aa4f33b095d50c252e065a1d8a patch 8.2.3205: Coverity reports a null pointer dereference Commit: https://github.com/vim/vim/commit/1b862c466ba4242857eec581f67982d265005ef4 Author: Bram Moolenaar Date: Fri Jul 23 19:30:19 2021 +0200 patch 8.2.3205: Coverity reports a null pointer dereference Problem: Coverity reports a null pointer dereference. Solution: Change the logic to avoid Coverity gets confused. diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3205, +/**/ 3204, /**/ 3203, diff --git a/src/vim9compile.c b/src/vim9compile.c --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -5175,14 +5175,14 @@ compile_and_or( cctx->ctx_lnum = start_ctx_lnum; status = check_ppconst_bool(ppconst); - if (status == OK) + if (status != FAIL) { // TODO: use ppconst if the value is a constant generate_ppconst(cctx, ppconst); // Every part must evaluate to a bool. - status = (bool_on_stack(cctx)); - if (status == OK) + status = bool_on_stack(cctx); + if (status != FAIL) status = ga_grow(&end_ga, 1); } cctx->ctx_lnum = save_lnum;