# HG changeset patch # User Bram Moolenaar # Date 1625851806 -7200 # Node ID 6c75baaa54ee1e39508420e7eb1d478426a87352 # Parent aa10290ecb6fc4007aaa541e9ed2d43dc228e4ab patch 8.2.3133: Vim9: memory leak when add() fails Commit: https://github.com/vim/vim/commit/90fba5627b361dbc970b3afc2eebf7411c49a0cc Author: Bram Moolenaar Date: Fri Jul 9 19:17:55 2021 +0200 patch 8.2.3133: Vim9: memory leak when add() fails Problem: Vim9: memory leak when add() fails. Solution: Allocate listitem_T after type check. diff --git a/src/list.c b/src/list.c --- a/src/list.c +++ b/src/list.c @@ -602,11 +602,12 @@ list_append(list_T *l, listitem_T *item) int list_append_tv(list_T *l, typval_T *tv) { - listitem_T *li = listitem_alloc(); + listitem_T *li; if (l->lv_type != NULL && l->lv_type->tt_member != NULL && check_typval_arg_type(l->lv_type->tt_member, tv, 0) == FAIL) return FAIL; + li = listitem_alloc(); if (li == NULL) return FAIL; copy_tv(tv, &li->li_tv); diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3133, +/**/ 3132, /**/ 3131,