# HG changeset patch # User Bram Moolenaar # Date 1612386004 -3600 # Node ID 7517eb94239b02c216dfef9d7bf23ec81d66cf8b # Parent 0df5534e8ddbf74fac2644a5dd49b0057075e25b patch 8.2.2464: using freed memory if window closed in autocommand Commit: https://github.com/vim/vim/commit/8ab375706e6712308f8cf7529bcae56684a6f385 Author: Bram Moolenaar Date: Wed Feb 3 21:56:59 2021 +0100 patch 8.2.2464: using freed memory if window closed in autocommand Problem: Using freed memory if window closed in autocommand. (houyunsong) Solution: Check the window still exists. diff --git a/src/ex_cmds.c b/src/ex_cmds.c --- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -2768,7 +2768,9 @@ do_ecmd( did_decrement = close_buffer(oldwin, curbuf, (flags & ECMD_HIDE) ? 0 : DOBUF_UNLOAD, FALSE, FALSE); - the_curwin->w_closing = FALSE; + // Autocommands may have closed the window. + if (win_valid(the_curwin)) + the_curwin->w_closing = FALSE; --buf->b_locked; #ifdef FEAT_EVAL diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim --- a/src/testdir/test_autocmd.vim +++ b/src/testdir/test_autocmd.vim @@ -2726,4 +2726,15 @@ func Test_BufNew_arglocal() au! BufNew endfunc +func Test_autocmd_closes_window() + au BufNew,BufWinLeave * e %e + file yyy + au BufNew,BufWinLeave * ball + call assert_fails('n xxx', 'E143:') + + bwipe % + au! BufNew + au! BufWinLeave +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 2464, +/**/ 2463, /**/ 2462,