# HG changeset patch # User Bram Moolenaar # Date 1598903103 -7200 # Node ID 2b6d696b063d0bffa05f0fa80c0c8c1d2a252df4 # Parent 35e1f299493eb8187af58cdb9ad0fb16c19b04a5 patch 8.2.1555: not all tests are executed on Github Actions Commit: https://github.com/vim/vim/commit/7d6979608ee83b06ccfab2589da3047b143defae Author: Bram Moolenaar Date: Mon Aug 31 21:30:32 2020 +0200 patch 8.2.1555: not all tests are executed on Github Actions Problem: Not all tests are executed on Github Actions. Solution: Copy "src" to "src2" earlier. Recognize "src2" in a couple more places. Add two tests to the list of flaky tests. (Ken Takata, closes #6798) diff --git a/.github/workflows/ci-windows.yaml b/.github/workflows/ci-windows.yaml --- a/.github/workflows/ci-windows.yaml +++ b/.github/workflows/ci-windows.yaml @@ -127,6 +127,11 @@ jobs: ) goto :eof + - name: Copy src directory to src2 + shell: cmd + run: | + xcopy src src2\ /E > nul + - name: Build (MSVC) if: matrix.toolchain == 'msvc' shell: cmd @@ -196,10 +201,6 @@ jobs: echo %COL_GREEN%vim version:%COL_RESET% .\vim --version || exit 1 - mkdir ..\src2 - xcopy testdir ..\src2\testdir\ /E > nul || exit 1 - copy evalfunc.c ..\src2 > nul - echo %COL_GREEN%Start testing vim in background.%COL_RESET% start cmd /c "cd ..\src2\testdir & nmake -nologo -f Make_dos.mak VIMPROG=..\..\src\vim > nul & echo done>done.txt" diff --git a/src/testdir/runtest.vim b/src/testdir/runtest.vim --- a/src/testdir/runtest.vim +++ b/src/testdir/runtest.vim @@ -382,7 +382,9 @@ endif " Names of flaky tests. let s:flaky_tests = [ + \ 'Test_BufWrite_lockmarks()', \ 'Test_autocmd_SafeState()', + \ 'Test_bufunload_all()', \ 'Test_client_server()', \ 'Test_close_and_exit_cb()', \ 'Test_close_output_buffer()', diff --git a/src/testdir/test_python2.vim b/src/testdir/test_python2.vim --- a/src/testdir/test_python2.vim +++ b/src/testdir/test_python2.vim @@ -2412,7 +2412,7 @@ func Test_python_chdir() cb.append(vim.eval('@%')) os.chdir('..') path = fnamemodify('.', ':p:h:t') - if path != 'src': + if path != 'src' and path != 'src2': # Running tests from a shadow directory, so move up another level # This will result in @% looking like shadow/testdir/Xfile, hence the # extra fnamemodify @@ -2422,7 +2422,8 @@ func Test_python_chdir() os.chdir(path) del path else: - cb.append(fnamemodify('.', ':p:h:t')) + # Also accept running from src2/testdir/ for MS-Windows CI. + cb.append(fnamemodify('.', ':p:h:t').replace('src2', 'src')) cb.append(vim.eval('@%').replace(os.path.sep, '/')) os.chdir('testdir') cb.append(fnamemodify('.', ':p:h:t')) diff --git a/src/testdir/test_python3.vim b/src/testdir/test_python3.vim --- a/src/testdir/test_python3.vim +++ b/src/testdir/test_python3.vim @@ -2591,7 +2591,7 @@ func Test_python3_chdir() cb.append(vim.eval('@%')) os.chdir('..') path = fnamemodify('.', ':p:h:t') - if path != b'src': + if path != b'src' and path != b'src2': # Running tests from a shadow directory, so move up another level # This will result in @% looking like shadow/testdir/Xfile, hence the # slicing to remove the leading path and path separator @@ -2600,7 +2600,8 @@ func Test_python3_chdir() cb.append(vim.eval('@%')[len(path)+1:].replace(os.path.sep, '/')) os.chdir(path) else: - cb.append(str(fnamemodify('.', ':p:h:t'))) + # Also accept running from src2/testdir/ for MS-Windows CI. + cb.append(str(fnamemodify('.', ':p:h:t').replace(b'src2', b'src'))) cb.append(vim.eval('@%').replace(os.path.sep, '/')) del path os.chdir('testdir') diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1555, +/**/ 1554, /**/ 1553,