# HG changeset patch # User Bram Moolenaar # Date 1598035504 -7200 # Node ID 1fc2ffadf4121af3b522b545de653f269626a761 # Parent ef5cd8d9a8b3ba10b7268361d566337b85bd91b7 patch 8.2.1501: Vim9: concatenating to constant reverses order Commit: https://github.com/vim/vim/commit/3fc71285d5ae7c16cf7be5d997fd1fe140f196da Author: Bram Moolenaar Date: Fri Aug 21 20:43:17 2020 +0200 patch 8.2.1501: Vim9: concatenating to constant reverses order Problem: Vim9: concatenating to constant reverses order. Solution: Generate constant before option, register and environment variable. (closes #6757) diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -944,6 +944,18 @@ def Test_expr5() + g:ablob) assert_equal(0z01ab3344, g:ablob + 0z3344) assert_equal(0z01ab01ab, g:ablob + g:ablob) + + # concatenate non-constant to constant + let save_path = &path + &path = 'b' + assert_equal('ab', 'a' .. &path) + &path = save_path + + @b = 'b' + assert_equal('ab', 'a' .. @b) + + $ENVVAR = 'env' + assert_equal('aenv', 'a' .. $ENVVAR) enddef def Test_expr5_vim9script() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1501, +/**/ 1500, /**/ 1499, diff --git a/src/vim9compile.c b/src/vim9compile.c --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -3402,19 +3402,25 @@ compile_expr7( /* * Option value: &name */ - case '&': ret = compile_get_option(arg, cctx); + case '&': if (generate_ppconst(cctx, ppconst) == FAIL) + return FAIL; + ret = compile_get_option(arg, cctx); break; /* * Environment variable: $VAR. */ - case '$': ret = compile_get_env(arg, cctx); + case '$': if (generate_ppconst(cctx, ppconst) == FAIL) + return FAIL; + ret = compile_get_env(arg, cctx); break; /* * Register contents: @r. */ - case '@': ret = compile_get_register(arg, cctx); + case '@': if (generate_ppconst(cctx, ppconst) == FAIL) + return FAIL; + ret = compile_get_register(arg, cctx); break; /* * nested expression: (expression).