# HG changeset patch # User Bram Moolenaar # Date 1562942705 -7200 # Node ID 1ac1d34bbdbfc11570413ff226f28a26bee85edf # Parent 65c1e105c8ab4ebe0704e61408ee1f6600fdb521 patch 8.1.1666: click in popup window scrollbar with border doesn't scroll commit https://github.com/vim/vim/commit/bd42b31780794fa751597cf3aa4d1d01889b1494 Author: Bram Moolenaar Date: Fri Jul 12 16:35:34 2019 +0200 patch 8.1.1666: click in popup window scrollbar with border doesn't scroll Problem: Click in popup window scrollbar with border doesn't scroll. Solution: Correct column for the border. (Naruhiko Nishino, closes https://github.com/vim/vim/issues/4650) diff --git a/src/popupwin.c b/src/popupwin.c --- a/src/popupwin.c +++ b/src/popupwin.c @@ -317,7 +317,7 @@ popup_handle_scrollbar_click(win_T *wp, return; if (row >= wp->w_popup_border[0] && row < height - wp->w_popup_border[2] - && col == popup_width(wp) - 1) + && col == popup_width(wp) - wp->w_popup_border[1] - 1) { if (row >= height / 2) { diff --git a/src/testdir/dumps/Test_popupwin_scroll_9.dump b/src/testdir/dumps/Test_popupwin_scroll_9.dump --- a/src/testdir/dumps/Test_popupwin_scroll_9.dump +++ b/src/testdir/dumps/Test_popupwin_scroll_9.dump @@ -1,10 +1,10 @@ >1+0&#ffffff0| @73 |2| @73 -|3| @73 -|4| @31|f+0#0000001#ffd7ff255|i|v|e| @3| +0#0000000#ff404010| +0&#ffffff0@32 -|5| @31|s+0#0000001#ffd7ff255|i|x| @4| +0#0000000#ff404010| +0&#ffffff0@32 -|6| @31|s+0#0000001#ffd7ff255|e|v|e|n| @2| +0#0000000#4040ff13| +0&#ffffff0@32 -|7| @31|e+0#0000001#ffd7ff255|i|g|h|t| @2| +0#0000000#4040ff13| +0&#ffffff0@32 -|8| @73 +|3| @30|╔+0#0000001#ffd7ff255|═@8|X| +0#0000000#ffffff0@31 +|4| @30|║+0#0000001#ffd7ff255|f|i|v|e| @3| +0#0000000#ff404010|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|5| @30|║+0#0000001#ffd7ff255|s|i|x| @4| +0#0000000#ff404010|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|6| @30|║+0#0000001#ffd7ff255|s|e|v|e|n| @2| +0#0000000#4040ff13|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|7| @30|║+0#0000001#ffd7ff255|e|i|g|h|t| @2| +0#0000000#4040ff13|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|8| @30|╚+0#0000001#ffd7ff255|═@8|╝| +0#0000000#ffffff0@31 |9| @73 |:|c|a|l@1| |C|l|i|c|k|B|o|t|(|)| @40|1|,|1| @10|T|o|p| diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim --- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -1580,6 +1580,7 @@ func Test_popup_scrollbar() call feedkeys("\\", "xt") endfunc func ClickBot() + call popup_setoptions(g:winid, {'border': [], 'close': 'button'}) call feedkeys("\\", "xt") endfunc map :call test_setmouse(5, 36) diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -778,6 +778,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1666, +/**/ 1665, /**/ 1664,