# HG changeset patch # User Bram Moolenaar # Date 1549832408 -3600 # Node ID aa80c63f34bbd8be05b6f8411093b06b8f01588a # Parent fa2b1f8d6203d9b5aeaf12332e615cdd60ab1b84 patch 8.1.0887: the 'l' flag in :subsitute is sticky commit https://github.com/vim/vim/commit/9474716d39764ac5642e55b5548580cf53bd9bed Author: Bram Moolenaar Date: Sun Feb 10 21:55:26 2019 +0100 patch 8.1.0887: the 'l' flag in :subsitute is sticky Problem: The 'l' flag in :subsitute is sticky. Solution: Reset the flag. (Dominique Pelle, closes https://github.com/vim/vim/issues/3925) diff --git a/src/ex_cmds.c b/src/ex_cmds.c --- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -2098,7 +2098,7 @@ write_viminfo(char_u *file, int forceit) fp_out = NULL; # ifdef EEXIST /* Avoid trying lots of names while the problem is lack - * of premission, only retry if the file already + * of permission, only retry if the file already * exists. */ if (errno != EEXIST) break; @@ -5040,6 +5040,7 @@ do_sub(exarg_T *eap) } subflags.do_error = TRUE; subflags.do_print = FALSE; + subflags.do_list = FALSE; subflags.do_count = FALSE; subflags.do_number = FALSE; subflags.do_ic = 0; diff --git a/src/testdir/test_substitute.vim b/src/testdir/test_substitute.vim --- a/src/testdir/test_substitute.vim +++ b/src/testdir/test_substitute.vim @@ -107,6 +107,32 @@ func Test_substitute_variants() endfor endfunc +" Test the l, p, # flags. +func Test_substitute_flags_lp() + new + call setline(1, "abc\tdef\ghi") + + let a = execute('s/a/a/p') + call assert_equal("\nabc def^Hghi", a) + + let a = execute('s/a/a/l') + call assert_equal("\nabc^Idef^Hghi$", a) + + let a = execute('s/a/a/#') + call assert_equal("\n 1 abc def^Hghi", a) + + let a = execute('s/a/a/p#') + call assert_equal("\n 1 abc def^Hghi", a) + + let a = execute('s/a/a/l#') + call assert_equal("\n 1 abc^Idef^Hghi$", a) + + let a = execute('s/a/a/') + call assert_equal("", a) + + bwipe! +endfunc + func Test_substitute_repeat() " This caused an invalid memory access. split Xfile diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -784,6 +784,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 887, +/**/ 886, /**/ 885,