# HG changeset patch # User Christian Brabandt # Date 1513699208 -3600 # Node ID a1f8939a46443ec2a30782ac216319cbf20f0e88 # Parent 519ff3efa2e233f917689b4d19a5d2e6bfac498d patch 8.0.1414: accessing freed memory in :lfile. commit https://github.com/vim/vim/commit/14a4deb064610c30a50f00d524dde9b3292aad59 Author: Bram Moolenaar Date: Tue Dec 19 16:48:55 2017 +0100 patch 8.0.1414: accessing freed memory in :lfile. Problem: Accessing freed memory in :lfile. Solution: Get the current window after executing autocommands. (Yegappan Lakshmanan, closes #2473) diff --git a/src/quickfix.c b/src/quickfix.c --- a/src/quickfix.c +++ b/src/quickfix.c @@ -4068,10 +4068,6 @@ ex_cfile(exarg_T *eap) #endif int res; - if (eap->cmdidx == CMD_lfile || eap->cmdidx == CMD_lgetfile - || eap->cmdidx == CMD_laddfile) - wp = curwin; - #ifdef FEAT_AUTOCMD switch (eap->cmdidx) { @@ -4104,6 +4100,11 @@ ex_cfile(exarg_T *eap) if (*eap->arg != NUL) set_string_option_direct((char_u *)"ef", -1, eap->arg, OPT_FREE, 0); + if (eap->cmdidx == CMD_lfile + || eap->cmdidx == CMD_lgetfile + || eap->cmdidx == CMD_laddfile) + wp = curwin; + /* * This function is used by the :cfile, :cgetfile and :caddfile * commands. diff --git a/src/testdir/test_quickfix.vim b/src/testdir/test_quickfix.vim --- a/src/testdir/test_quickfix.vim +++ b/src/testdir/test_quickfix.vim @@ -3031,3 +3031,10 @@ func Test_ll_window_ctx() enew | only endfunc +" The following test used to crash vim +func Test_lfile_crash() + sp Xtest + au QuickFixCmdPre * bw + call assert_fails('lfile', 'E40') + au! QuickFixCmdPre +endfunc diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -772,6 +772,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1414, +/**/ 1413, /**/ 1412,