# HG changeset patch # User Christian Brabandt # Date 1458843309 -3600 # Node ID 31f9fa8e153208fe5f5552ef5145f55cec908d24 # Parent dffcd5b20b98261ba2d7b1beaf4bcfa113b5c0dc commit https://github.com/vim/vim/commit/d4caf5c16a9f1c9477d426e58d8d3dc47ab5f066 Author: Bram Moolenaar Date: Thu Mar 24 19:14:35 2016 +0100 patch 7.4.1643 Problem: Terminating file name has side effects. Solution: Restore the character. (mostly by James McCoy, closes https://github.com/vim/vim/issues/713) diff --git a/src/eval.c b/src/eval.c --- a/src/eval.c +++ b/src/eval.c @@ -26440,8 +26440,10 @@ repeat: if (src[*usedlen] == ':' && src[*usedlen + 1] == 'S') { /* vim_strsave_shellescape() needs a NUL terminated string. */ + c = (*fnamep)[*fnamelen]; (*fnamep)[*fnamelen] = NUL; p = vim_strsave_shellescape(*fnamep, FALSE, FALSE); + (*fnamep)[*fnamelen] = c; if (p == NULL) return -1; vim_free(*bufp); diff --git a/src/testdir/test105.in b/src/testdir/test105.in --- a/src/testdir/test105.in +++ b/src/testdir/test105.in @@ -36,6 +36,7 @@ STARTTEST :Put fnamemodify('abc''%''def', ':S' ) :Put fnamemodify("abc\ndef", ':S' ) :Put expand('%:r:S') == shellescape(expand('%:r')) +:Put join([expand('%:r'), expand('%:r:S'), expand('%')], ',') :set shell=tcsh :Put fnamemodify("abc\ndef", ':S' ) :$put ='vim: ts=8' diff --git a/src/testdir/test105.ok b/src/testdir/test105.ok --- a/src/testdir/test105.ok +++ b/src/testdir/test105.ok @@ -26,5 +26,6 @@ fnamemodify('abc'' ''def', ':S' fnamemodify('abc''%''def', ':S' ) '''abc''\''''%''\''''def''' fnamemodify("abc\ndef", ':S' ) '''abc^@def''' expand('%:r:S') == shellescape(expand('%:r')) 1 +join([expand('%:r'), expand('%:r:S'), expand('%')], ',') 'test105,''test105'',test105.in' fnamemodify("abc\ndef", ':S' ) '''abc\^@def''' vim: ts=8 diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -749,6 +749,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1643, +/**/ 1642, /**/ 1641,