# HG changeset patch # User Bram Moolenaar # Date 1562013005 -7200 # Node ID e9ebf3f27af6792e730d78c4cf1afa9f3e67ec98 # Parent eaf422739e2620d7cfe956059035cd617f9c7b8a patch 8.1.1615: crash when passing buffer number to popup_create() commit https://github.com/vim/vim/commit/7866b87958cf0c2f3312f2c3d7fb8d6eed28b512 Author: Bram Moolenaar Date: Mon Jul 1 22:21:01 2019 +0200 patch 8.1.1615: crash when passing buffer number to popup_create() Problem: Crash when passing buffer number to popup_create(). (Yasuhiro Matsumoto) Solution: Initialze the window properly. diff --git a/src/popupwin.c b/src/popupwin.c --- a/src/popupwin.c +++ b/src/popupwin.c @@ -1056,8 +1056,7 @@ popup_create(typval_T *argvars, typval_T { // use existing buffer new_buffer = FALSE; - wp->w_buffer = buf; - ++buf->b_nwindows; + win_init_popup_win(wp, buf); buffer_ensure_loaded(buf); } else diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim --- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -1668,4 +1668,9 @@ func Test_popupwin_with_buffer() call assert_equal({}, popup_getpos(winid)) call assert_equal(1, bufloaded(buf)) exe 'bwipe! ' .. buf + + edit test_popupwin.vim + let winid = popup_create(bufnr(''), {}) + redraw + call popup_close(winid) endfunc diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -778,6 +778,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1615, +/**/ 1614, /**/ 1613,