# HG changeset patch # User Bram Moolenaar # Date 1559393104 -7200 # Node ID cdca5f577c36722034df097abc2882c758ea8de4 # Parent df19064e8d010b495d84923f32de58cd2ba84f4e patch 8.1.1439: json_encode() is very slow for large results commit https://github.com/vim/vim/commit/c47ed44be76a520ded90913099771999c8a79eeb Author: Bram Moolenaar Date: Sat Jun 1 14:36:26 2019 +0200 patch 8.1.1439: json_encode() is very slow for large results Problem: Json_encode() is very slow for large results. Solution: In the growarray use a growth of at least 50%. (Ken Takata, closes #4461) diff --git a/src/misc2.c b/src/misc2.c --- a/src/misc2.c +++ b/src/misc2.c @@ -2057,6 +2057,13 @@ ga_grow(garray_T *gap, int n) { if (n < gap->ga_growsize) n = gap->ga_growsize; + + // A linear growth is very inefficient when the array grows big. This + // is a compromise between allocating memory that won't be used and too + // many copy operations. A factor of 1.5 seems reasonable. + if (n < gap->ga_len / 2) + n = gap->ga_len / 2; + new_len = gap->ga_itemsize * (gap->ga_len + n); pp = vim_realloc(gap->ga_data, new_len); if (pp == NULL) diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -768,6 +768,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1439, +/**/ 1438, /**/ 1437,