# HG changeset patch # User Christian Brabandt # Date 1487509205 -3600 # Node ID b69194114994c553f2b6e816024296b0fe0b0301 # Parent 886bce9d79d2b3392119c839e7b670f26b8a6196 patch 8.0.0340: not checking return valud of dict_add() commit https://github.com/vim/vim/commit/5acff71d3bd7796ee0a112ceb891af630b59304e Author: Bram Moolenaar Date: Sun Feb 19 13:55:02 2017 +0100 patch 8.0.0340: not checking return valud of dict_add() Problem: Not checking return valud of dict_add(). (Coverity) Solution: Handle a failure. diff --git a/src/buffer.c b/src/buffer.c --- a/src/buffer.c +++ b/src/buffer.c @@ -888,8 +888,13 @@ init_changedtick(buf_T *buf) di->di_tv.v_type = VAR_NUMBER; di->di_tv.v_lock = VAR_FIXED; di->di_tv.vval.v_number = 0; - dict_add(buf->b_vars, di); - buf->b_changedtick = &di->di_tv.vval.v_number; + if (dict_add(buf->b_vars, di) == OK) + buf->b_changedtick = &di->di_tv.vval.v_number; + else + { + vim_free(di); + buf->b_changedtick = &buf->b_ct_val; + } } else #endif diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -765,6 +765,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 340, +/**/ 339, /**/ 338,