# HG changeset patch
# User Bram Moolenaar <Bram@vim.org>
# Date 1652024702 -7200
# Node ID acca2214cabfc173d5f3b6740545f90a5caf1a7e
# Parent  4185037f5051fc712d1efe2dc300a0b9ec813e1e
patch 8.2.4914: string interpolation in :def function may fail

Commit: https://github.com/vim/vim/commit/933c2922b5e81b238c2e56361c76cf7c9548a2d7
Author: Bram Moolenaar <Bram@vim.org>
Date:   Sun May 8 16:37:07 2022 +0100

    patch 8.2.4914: string interpolation in :def function may fail

    Problem:    String interpolation in :def function may fail.
    Solution:   Do not terminate the expression. (closes https://github.com/vim/vim/issues/10377)

diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim
--- a/src/testdir/test_vim9_expr.vim
+++ b/src/testdir/test_vim9_expr.vim
@@ -2143,6 +2143,19 @@ def Test_expr8_string()
   v9.CheckDefAndScriptFailure(['var x = "abc'], 'E114:', 1)
   v9.CheckDefAndScriptFailure(["var x = 'abc"], 'E115:', 1)
   v9.CheckDefFailure(["if 0", "echo 'xx", "endif"], 'E115', 2)
+
+  # interpolated string
+  var val = 'val'
+  var vv = $"some {val}"
+  assert_equal('some val', vv)
+  vv = $'other {val}'
+  assert_equal('other val', vv)
+
+  var x = 'x'
+  var vl = 'foo xxx bar xxx baz'
+              ->split($'x{x}x')
+              ->map((_, v: string) => v =~ 'bar')
+  assert_equal([false, true, false], vl)
 enddef
 
 def Test_expr8_vimvar()
diff --git a/src/version.c b/src/version.c
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    4914,
+/**/
     4913,
 /**/
     4912,
diff --git a/src/vim9compile.c b/src/vim9compile.c
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -981,7 +981,6 @@ compile_all_expr_in_str(char_u *str, int
 {
     char_u	*p = str;
     char_u	*val;
-    char_u	save_c;
     int		count = 0;
 
     if (cctx->ctx_skip == SKIP_YES)
@@ -1051,11 +1050,8 @@ compile_all_expr_in_str(char_u *str, int
 	    semsg(_(e_missing_close_curly_str), str);
 	    return FAIL;
 	}
-	save_c = *block_end;
-	*block_end = NUL;
 	if (compile_expr0(&block_start, cctx) == FAIL)
 	    return FAIL;
-	*block_end = save_c;
 	may_generate_2STRING(-1, TRUE, cctx);
 	++count;