# HG changeset patch # User Christian Brabandt # Date 1487628904 -3600 # Node ID 8bff367672a4f2cebeab3c48a1cfc830b5f60b60 # Parent e155b0b3d53225a4e757228087dc05ccca627662 patch 8.0.0344: unlet command leaks memory commit https://github.com/vim/vim/commit/49439c4cdf7d2822255f292adda4226656fe144d Author: Bram Moolenaar Date: Mon Feb 20 23:07:05 2017 +0100 patch 8.0.0344: unlet command leaks memory Problem: Unlet command leaks memory. (Nikolai Pavlov) Solution: Free the memory on error. (closes https://github.com/vim/vim/issues/1497) diff --git a/src/eval.c b/src/eval.c --- a/src/eval.c +++ b/src/eval.c @@ -2079,7 +2079,10 @@ get_lval( } /* existing variable, need to check if it can be changed */ else if (var_check_ro(lp->ll_di->di_flags, name, FALSE)) + { + clear_tv(&var1); return NULL; + } if (len == -1) clear_tv(&var1); diff --git a/src/testdir/test_unlet.vim b/src/testdir/test_unlet.vim --- a/src/testdir/test_unlet.vim +++ b/src/testdir/test_unlet.vim @@ -17,3 +17,7 @@ func Test_not_existing() unlet! does_not_exist call assert_fails('unlet does_not_exist', 'E108:') endfunc + +func Test_unlet_fails() + call assert_fails('unlet v:["count"]', 'E46:') +endfunc diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -765,6 +765,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 344, +/**/ 343, /**/ 342,