# HG changeset patch # User Bram Moolenaar # Date 1590956103 -7200 # Node ID 8bce783af0cbd7d27d063d985b0e11009586a6c3 # Parent 38f728a93c07ecb56bd1a323e30a3783d4aef9f9 patch 8.2.0867: using {xxx} for encoding a modifier is not nice Commit: https://github.com/vim/vim/commit/fccd93f0917234b962ce07d1df3adf9d7105936f Author: Bram Moolenaar Date: Sun May 31 22:06:51 2020 +0200 patch 8.2.0867: using \{xxx} for encoding a modifier is not nice Problem: Using \{xxx} for encoding a modifier is not nice. Solution: Use \<*xxx> instead, since it's the same as \ but producing a different code. diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt --- a/runtime/doc/eval.txt +++ b/runtime/doc/eval.txt @@ -1353,8 +1353,8 @@ A string constant accepts these special To use the double quote character it must be escaped: "". Don't use to get a utf-8 character, use \uxxxx as mentioned above. -\{xxx} like \ but prepends a modifier instead of including it in the - character. E.g. "\" is one character 0x17 while "\{C-w}" is four +\<*xxx> Like \ but prepends a modifier instead of including it in the + character. E.g. "\" is one character 0x17 while "\<*C-w>" is four bytes: 3 for the CTRL modifier and then character "W". Note that "\xff" is stored as the byte 255, which may be invalid in some diff --git a/src/misc2.c b/src/misc2.c --- a/src/misc2.c +++ b/src/misc2.c @@ -2772,13 +2772,14 @@ find_special_key( int modifiers; int bit; int key; - int endchar = (flags & FSK_CURLY) ? '}' : '>'; uvarnumber_T n; int l; src = *srcp; - if (src[0] != ((flags & FSK_CURLY) ? '{' : '<')) + if (src[0] != '<') return 0; + if (src[1] == '*') // <*xxx>: do not simplify + ++src; // Find end of modifier list last_dash = src; @@ -2796,15 +2797,15 @@ find_special_key( // Anything accepted, like . // or are not special in strings as " is // the string delimiter. With a backslash it works: - if (!(in_string && bp[1] == '"') && bp[l + 1] == endchar) + if (!(in_string && bp[1] == '"') && bp[l + 1] == '>') bp += l; else if (in_string && bp[1] == '\\' && bp[2] == '"' - && bp[3] == endchar) + && bp[3] == '>') bp += 2; } } if (bp[0] == 't' && bp[1] == '_' && bp[2] && bp[3]) - bp += 3; // skip t_xx, xx may be '-' or '>'/'}' + bp += 3; // skip t_xx, xx may be '-' or '>' else if (STRNICMP(bp, "char-", 5) == 0) { vim_str2nr(bp + 5, NULL, &l, STR2NR_ALL, NULL, NULL, 0, TRUE); @@ -2818,7 +2819,7 @@ find_special_key( } } - if (*bp == endchar) // found matching '>' or '}' + if (*bp == '>') // found matching '>' { end_of_name = bp + 1; @@ -2864,7 +2865,7 @@ find_special_key( l = mb_ptr2len(last_dash + off); else l = 1; - if (modifiers != 0 && last_dash[l + off] == endchar) + if (modifiers != 0 && last_dash[l + off] == '>') key = PTR2CHAR(last_dash + off); else { diff --git a/src/testdir/test_backspace_opt.vim b/src/testdir/test_backspace_opt.vim --- a/src/testdir/test_backspace_opt.vim +++ b/src/testdir/test_backspace_opt.vim @@ -86,7 +86,7 @@ func Test_backspace_ctrl_u() set cpo-=< inoremap - exe "normal Avim3\{C-U}\\" + exe "normal Avim3\<*C-U>\\" iunmap exe "normal Avim4\\\\" @@ -96,7 +96,7 @@ func Test_backspace_ctrl_u() exe "normal A vim6\Azwei\u\\\" inoremap - exe "normal A vim7\{C-U}\{C-U}\\" + exe "normal A vim7\<*C-U>\<*C-U>\\" call assert_equal([ \ "1 this shouldn't be deleted", diff --git a/src/testdir/test_mapping.vim b/src/testdir/test_mapping.vim --- a/src/testdir/test_mapping.vim +++ b/src/testdir/test_mapping.vim @@ -76,7 +76,7 @@ func Test_map_ctrl_c_insert() inoremap cnoremap dummy cunmap - call feedkeys("GoTEST2: CTRL-C |\{C-C}A|\", "xt") + call feedkeys("GoTEST2: CTRL-C |\<*C-C>A|\", "xt") call assert_equal('TEST2: CTRL-C |A|', getline('$')) unmap! set nomodified @@ -85,7 +85,7 @@ endfunc func Test_map_ctrl_c_visual() " mapping of ctrl-c in Visual mode vnoremap :$put ='vmap works' - call feedkeys("GV\{C-C}\", "xt") + call feedkeys("GV\<*C-C>\", "xt") call assert_equal('vmap works', getline('$')) vunmap set nomodified @@ -235,7 +235,7 @@ endfunc func Test_map_meta_quotes() imap foo - call feedkeys("Go-\{M-\"}-\", "xt") + call feedkeys("Go-\<*M-\">-\", "xt") call assert_equal("-foo-", getline('$')) set nomodified iunmap diff --git a/src/testdir/test_messages.vim b/src/testdir/test_messages.vim --- a/src/testdir/test_messages.vim +++ b/src/testdir/test_messages.vim @@ -306,7 +306,7 @@ endfunc func Test_mapping_at_hit_return_prompt() nnoremap :echo "hit ctrl-b" call feedkeys(":ls\", "xt") - call feedkeys("\{C-B}", "xt") + call feedkeys("\<*C-B>", "xt") call assert_match('hit ctrl-b', Screenline(&lines - 1)) nunmap endfunc diff --git a/src/typval.c b/src/typval.c --- a/src/typval.c +++ b/src/typval.c @@ -1285,16 +1285,13 @@ get_string_tv(char_u **arg, typval_T *re ++name; break; - // Special key, e.g.: "\" or "\{C-W}" + // Special key, e.g.: "\" case '<': - case '{': { int flags = FSK_KEYCODE | FSK_IN_STRING; - if (*p == '<') + if (p[1] != '*') flags |= FSK_SIMPLIFY; - else - flags |= FSK_CURLY; extra = trans_special(&p, name, flags, NULL); if (extra != 0) { diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -747,6 +747,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 867, +/**/ 866, /**/ 865, diff --git a/src/vim.h b/src/vim.h --- a/src/vim.h +++ b/src/vim.h @@ -2666,6 +2666,5 @@ long elapsed(DWORD start_tick); #define FSK_KEEP_X_KEY 0x02 // don't translate xHome to Home key #define FSK_IN_STRING 0x04 // TRUE in string, double quote is escaped #define FSK_SIMPLIFY 0x08 // simplify and -#define FSK_CURLY 0x10 // {C-x} instead of #endif // VIM__H