# HG changeset patch # User Bram Moolenaar # Date 1653230702 -7200 # Node ID 8207581dd0689e415da2f2a4425c8cbed9fb5cbc # Parent d79aa3eed38abf7cc538bdee6fe52f65dc1f71c7 patch 8.2.5002: deletebufline() may change Visual selection Commit: https://github.com/vim/vim/commit/9b2edfd3bf2f14a1faaee9b62930598a2e77a798 Author: LemonBoy Date: Sun May 22 15:35:53 2022 +0100 patch 8.2.5002: deletebufline() may change Visual selection Problem: deletebufline() may change Visual selection. Solution: Disable Visual mode when using another buffer. (closes https://github.com/vim/vim/issues/10469) diff --git a/src/evalbuffer.c b/src/evalbuffer.c --- a/src/evalbuffer.c +++ b/src/evalbuffer.c @@ -510,6 +510,7 @@ f_deletebufline(typval_T *argvars, typva tabpage_T *tp; win_T *wp; int did_emsg_before = did_emsg; + int save_VIsual_active = VIsual_active; rettv->vval.v_number = 1; // FAIL by default @@ -538,6 +539,7 @@ f_deletebufline(typval_T *argvars, typva if (!is_curbuf) { + VIsual_active = FALSE; curbuf_save = curbuf; curwin_save = curwin; curbuf = buf; @@ -582,6 +584,7 @@ f_deletebufline(typval_T *argvars, typva { curbuf = curbuf_save; curwin = curwin_save; + VIsual_active = save_VIsual_active; } rettv->vval.v_number = 0; // OK } diff --git a/src/testdir/test_bufline.vim b/src/testdir/test_bufline.vim --- a/src/testdir/test_bufline.vim +++ b/src/testdir/test_bufline.vim @@ -238,4 +238,21 @@ func Test_setbufline_select_mode() bwipe! endfunc +func Test_deletebufline_select_mode() + new + call setline(1, ['foo', 'bar']) + call feedkeys("j^v2l\", 'nx') + + let bufnr = bufadd('Xdummy') + call bufload(bufnr) + call setbufline(bufnr, 1, ['abc', 'def']) + call deletebufline(bufnr, 1) + + call feedkeys("x", 'nx') + call assert_equal(['foo', 'x'], getline(1, 2)) + + exe "bwipe! " .. bufnr + bwipe! +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -735,6 +735,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 5002, +/**/ 5001, /**/ 5000,