# HG changeset patch # User Christian Brabandt # Date 1527101106 -7200 # Node ID 5d6e8dedfc736bedfe26e45f8575b461400ce8bc # Parent 665fe1f419b0bc96e73fef825c7562a3cc5c2e93 patch 8.1.0021: clang warns for undefined behavior commit https://github.com/vim/vim/commit/d315cf551f1d15609c4d7cf724e471de55f5cdac Author: Bram Moolenaar Date: Wed May 23 20:30:56 2018 +0200 patch 8.1.0021: clang warns for undefined behavior Problem: Clang warns for undefined behavior. Solution: Move #ifdef outside of sprintf() call.(suggestion by Michael Jarvis, closes #2956) diff --git a/src/term.c b/src/term.c --- a/src/term.c +++ b/src/term.c @@ -2872,14 +2872,15 @@ term_color(char_u *s, int n) #else char *format = "%s%s%%dm"; #endif - sprintf(buf, format, - i == 2 ? + char *lead = i == 2 ? ( #if defined(FEAT_VTP) && defined(FEAT_TERMGUICOLORS) - s[1] == '|' ? IF_EB("\033|", ESC_STR "|") : + s[1] == '|' ? IF_EB("\033|", ESC_STR "|") : #endif - IF_EB("\033[", ESC_STR "[") : "\233", - s[i] == '3' ? (n >= 16 ? "38;5;" : "9") - : (n >= 16 ? "48;5;" : "10")); + IF_EB("\033[", ESC_STR "[")) : "\233"; + char *tail = s[i] == '3' ? (n >= 16 ? "38;5;" : "9") + : (n >= 16 ? "48;5;" : "10"); + + sprintf(buf, format, lead, tail); OUT_STR(tgoto(buf, 0, n >= 16 ? n : n - 8)); } else diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -762,6 +762,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 21, +/**/ 20, /**/ 19,