# HG changeset patch # User Bram Moolenaar # Date 1593455404 -7200 # Node ID 48cfc37fe4fc6d6fb2c77a5ddab31f45bf26ab80 # Parent 7758191b9cd5eddd63897f9f08b11802dde93202 patch 8.2.1084: Lua: registering function has useless code Commit: https://github.com/vim/vim/commit/7d2ac92ebc36049f9ce2f4ce08b8a80ca212ace2 Author: Bram Moolenaar Date: Mon Jun 29 20:20:33 2020 +0200 patch 8.2.1084: Lua: registering function has useless code Problem: Lua: registering function has useless code. Solution: Remove clearing grow arrays. diff --git a/src/userfunc.c b/src/userfunc.c --- a/src/userfunc.c +++ b/src/userfunc.c @@ -350,16 +350,11 @@ get_lambda_name(void) register_cfunc(cfunc_T cb, cfunc_free_T cb_free, void *state) { char_u *name = get_lambda_name(); - ufunc_T *fp = NULL; - garray_T newargs; - garray_T newlines; - - ga_init(&newargs); - ga_init(&newlines); + ufunc_T *fp; fp = alloc_clear(offsetof(ufunc_T, uf_name) + STRLEN(name) + 1); if (fp == NULL) - goto errret; + return NULL; fp->uf_dfunc_idx = UF_NOT_COMPILED; fp->uf_refcount = 1; @@ -367,8 +362,6 @@ register_cfunc(cfunc_T cb, cfunc_free_T fp->uf_flags = FC_CFUNC; fp->uf_calls = 0; fp->uf_script_ctx = current_sctx; - fp->uf_lines = newlines; - fp->uf_args = newargs; fp->uf_cb = cb; fp->uf_cb_free = cb_free; fp->uf_cb_state = state; @@ -377,12 +370,6 @@ register_cfunc(cfunc_T cb, cfunc_free_T hash_add(&func_hashtab, UF2HIKEY(fp)); return name; - -errret: - ga_clear_strings(&newargs); - ga_clear_strings(&newlines); - vim_free(fp); - return NULL; } #endif diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1084, +/**/ 1083, /**/ 1082,