# HG changeset patch # User Bram Moolenaar # Date 1566238504 -7200 # Node ID 3f0fd418ac1dffd53384b16ad5b5a03ecf7e0325 # Parent 0a3a42786ec882ead69dfb3185424f739e9921d3 patch 8.1.1889: Coverity warns for using a NULL pointer commit https://github.com/vim/vim/commit/ea7ecfe2a08877f98edec9b9c26b9e1b3673f00b Author: Bram Moolenaar Date: Mon Aug 19 20:08:15 2019 +0200 patch 8.1.1889: Coverity warns for using a NULL pointer Problem: Coverity warns for using a NULL pointer. Solution: Use zero for column if pos is NULL. diff --git a/src/netbeans.c b/src/netbeans.c --- a/src/netbeans.c +++ b/src/netbeans.c @@ -1389,17 +1389,18 @@ nb_do_cmd( && ((pos != NULL && pos->col > 0) || (lnum == 1 && buf_was_empty))) { - char_u *oldline = ml_get(lnum); - char_u *newline; + char_u *oldline = ml_get(lnum); + char_u *newline; + int col = pos == NULL ? 0 : pos->col; /* Insert halfway a line. */ newline = alloc(STRLEN(oldline) + len + 1); if (newline != NULL) { - mch_memmove(newline, oldline, (size_t)pos->col); - newline[pos->col] = NUL; + mch_memmove(newline, oldline, (size_t)col); + newline[col] = NUL; STRCAT(newline, args); - STRCAT(newline, oldline + pos->col); + STRCAT(newline, oldline + col); ml_replace(lnum, newline, FALSE); } } diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -766,6 +766,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1889, +/**/ 1888, /**/ 1887,