# HG changeset patch
# User Bram Moolenaar <Bram@vim.org>
# Date 1608571804 -3600
# Node ID 22d0c25869d87cffe36c09bd978184832544126e
# Parent  50c3cbc5b9b2f54e88564de02aa65f9e91599b0f
patch 8.2.2181: valgrind warnings for using uninitialized value

Commit: https://github.com/vim/vim/commit/a3d10a508c404a32485adc86284725e0bdc5b602
Author: Bram Moolenaar <Bram@vim.org>
Date:   Mon Dec 21 18:24:00 2020 +0100

    patch 8.2.2181: valgrind warnings for using uninitialized value

    Problem:    Valgrind warnings for using uninitialized value.
    Solution:   Do not use "start" or "end" unless there is a match.

diff --git a/src/regexp_bt.c b/src/regexp_bt.c
--- a/src/regexp_bt.c
+++ b/src/regexp_bt.c
@@ -4805,21 +4805,24 @@ theend:
     if (backpos.ga_maxlen > BACKPOS_INITIAL)
 	ga_clear(&backpos);
 
-    // Make sure the end is never before the start.  Can happen when \zs and
-    // \ze are used.
-    if (REG_MULTI)
+    if (retval > 0)
     {
-	lpos_T *start = &rex.reg_mmatch->startpos[0];
-	lpos_T *end = &rex.reg_mmatch->endpos[0];
-
-	if (end->lnum < start->lnum
+	// Make sure the end is never before the start.  Can happen when \zs
+	// and \ze are used.
+	if (REG_MULTI)
+	{
+	    lpos_T *start = &rex.reg_mmatch->startpos[0];
+	    lpos_T *end = &rex.reg_mmatch->endpos[0];
+
+	    if (end->lnum < start->lnum
 			|| (end->lnum == start->lnum && end->col < start->col))
-	    rex.reg_mmatch->endpos[0] = rex.reg_mmatch->startpos[0];
-    }
-    else
-    {
-	if (rex.reg_match->endp[0] < rex.reg_match->startp[0])
-	    rex.reg_match->endp[0] = rex.reg_match->startp[0];
+		rex.reg_mmatch->endpos[0] = rex.reg_mmatch->startpos[0];
+	}
+	else
+	{
+	    if (rex.reg_match->endp[0] < rex.reg_match->startp[0])
+		rex.reg_match->endp[0] = rex.reg_match->startp[0];
+	}
     }
 
     return retval;
diff --git a/src/regexp_nfa.c b/src/regexp_nfa.c
--- a/src/regexp_nfa.c
+++ b/src/regexp_nfa.c
@@ -7227,21 +7227,24 @@ nfa_regexec_both(
 #endif
 
 theend:
-    // Make sure the end is never before the start.  Can happen when \zs and
-    // \ze are used.
-    if (REG_MULTI)
+    if (retval > 0)
     {
-	lpos_T *start = &rex.reg_mmatch->startpos[0];
-	lpos_T *end = &rex.reg_mmatch->endpos[0];
-
-	if (end->lnum < start->lnum
+	// Make sure the end is never before the start.  Can happen when \zs and
+	// \ze are used.
+	if (REG_MULTI)
+	{
+	    lpos_T *start = &rex.reg_mmatch->startpos[0];
+	    lpos_T *end = &rex.reg_mmatch->endpos[0];
+
+	    if (end->lnum < start->lnum
 			|| (end->lnum == start->lnum && end->col < start->col))
-	    rex.reg_mmatch->endpos[0] = rex.reg_mmatch->startpos[0];
-    }
-    else if (retval > 0)
-    {
-	if (rex.reg_match->endp[0] < rex.reg_match->startp[0])
-	    rex.reg_match->endp[0] = rex.reg_match->startp[0];
+		rex.reg_mmatch->endpos[0] = rex.reg_mmatch->startpos[0];
+	}
+	else
+	{
+	    if (rex.reg_match->endp[0] < rex.reg_match->startp[0])
+		rex.reg_match->endp[0] = rex.reg_match->startp[0];
+	}
     }
 
     return retval;
diff --git a/src/version.c b/src/version.c
--- a/src/version.c
+++ b/src/version.c
@@ -751,6 +751,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2181,
+/**/
     2180,
 /**/
     2179,