Mercurial > vim
view src/testdir/test_wnext.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 28 Mar 2024 12:15:03 +0100 |
| parents | 08940efa6b4e |
| children |
line wrap: on
line source
" Test :wnext :wNext and :wprevious func Test_wnext() args X1 X2 call setline(1, '1') wnext call assert_equal(['1'], readfile('X1')) call assert_equal('X2', bufname('%')) call setline(1, '2') call assert_fails('wnext', 'E165:') call assert_equal(['2'], readfile('X2')) call assert_equal('X2', bufname('%')) " Test :wnext with a single file. args X1 call assert_equal('X1', bufname('%')) call assert_fails('wnext', 'E163:') " Test :wnext with a count. args X1 X2 X3 call assert_equal('X1', bufname('%')) 2wnext call assert_equal('X3', bufname('%')) " Test :wnext {file}. args X1 X2 X3 wnext X4 call assert_equal(['1'], readfile('X4')) call assert_equal('X2', bufname('%')) call assert_fails('wnext X4', 'E13:') call assert_equal(['1'], readfile('X4')) wnext! X4 call assert_equal(['2'], readfile('X4')) call assert_equal('X3', bufname('%')) args X1 X2 " Commented out as, E13 occurs on Windows instead of E17 "call assert_fails('wnext .', 'E17:') call assert_fails('wnext! .', 'E502:') %bwipe! call delete('X1') call delete('X2') call delete('X3') call delete('X4') endfunc func Test_wprevious() args X1 X2 next call assert_equal('X2', bufname('%')) call setline(1, '2') wprevious call assert_equal(['2'], readfile('X2')) call assert_equal('X1', bufname('%')) call setline(1, '1') call assert_fails('wprevious', 'E164:') call assert_fails('wNext', 'E164:') " Test :wprevious with a single file. args X1 call assert_fails('wprevious', 'E163:') call assert_fails('wNext', 'E163:') " Test :wprevious with a count. args X1 X2 X3 2next call setline(1, '3') call assert_equal('X3', bufname('%')) 2wprevious call assert_equal('X1', bufname('%')) call assert_equal(['3'], readfile('X3')) " Test :wprevious {file} args X1 X2 X3 2next call assert_equal('X3', bufname('%')) wprevious X4 call assert_equal(['3'], readfile('X4')) call assert_equal('X2', bufname('%')) call assert_fails('wprevious X4', 'E13:') call assert_equal(['3'], readfile('X4')) wprevious! X4 call assert_equal(['2'], readfile('X4')) call assert_equal('X1', bufname('%')) args X1 X2 " Commented out as, E13 occurs on Windows instead of E17 "call assert_fails('wprevious .', 'E17:') call assert_fails('wprevious! .', 'E502:') %bwipe! call delete('X1') call delete('X2') call delete('X3') call delete('X4') endfunc " vim: shiftwidth=2 sts=2 expandtab