Mercurial > vim
view src/testdir/test_backup.vim @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 28 Mar 2024 12:15:03 +0100 |
| parents | ba5ca7c7d44c |
| children |
line wrap: on
line source
" Tests for the backup function source check.vim func Test_backup() set backup backupdir=. backupskip= new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt let l = readfile('Xbackup.txt~') call assert_equal(['line1', 'line2'], l) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup_backupskip() set backup backupdir=. backupskip=*.txt new call setline(1, ['line1', 'line2']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt call assert_false(filereadable('Xbackup.txt~')) bw! set backup&vim backupdir&vim backupskip&vim call delete('Xbackup.txt') call delete('Xbackup.txt~') endfunc func Test_backup2() set backup backupdir=.// backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupskip&vim endfunc func Test_backup2_backupcopy() set backup backupdir=.// backupcopy=yes backupskip= new call setline(1, ['line1', 'line2', 'line3']) :f Xbackup.txt :w! Xbackup.txt " backup file is only created after " writing a second time (before overwriting) :w! Xbackup.txt sp *Xbackup.txt~ call assert_equal(['line1', 'line2', 'line3'], getline(1,'$')) let f = expand('%') call assert_match('%testdir%Xbackup.txt\~', f) bw! bw! call delete('Xbackup.txt') call delete(f) set backup&vim backupdir&vim backupcopy&vim backupskip&vim endfunc " Test for using a non-existing directory as a backup directory func Test_non_existing_backupdir() set backupdir=./non_existing_dir backupskip= call writefile(['line1'], 'Xbackupdir', 'D') new Xbackupdir call assert_fails('write', 'E510:') set backupdir&vim backupskip&vim endfunc " vim: shiftwidth=2 sts=2 expandtab