patch 9.1.0068: Visual highlighting can still be improved Commit: https://github.com/vim/vim/commit/59bafc8171b08cf326ed40ccb4ee917f9643290e Author: Maxim Kim <habamax@gmail.com> Date: Thu Feb 1 21:07:51 2024 +0100 patch 9.1.0068: Visual highlighting can still be improved Problem: Visual highlighting can still be improved Solution: Update Visual highlighting for 8 color terminals, use uniform grey highlighting for dark and light bg (Maxim Kim) Update terminal Visual 1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right closes: #13940 Signed-off-by: Maxim Kim <habamax@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

vim9script

# Extra functionality for displaying Vim help .

# Called when editing the doc/syntax.txt file
export def HighlightGroups()
  var save_cursor = getcurpos()
  var buf: number = bufnr('%')

  var start: number = search('\*highlight-groups\*', 'c')
  var end: number = search('^======')
  for lnum in range(start, end)
    var word: string = getline(lnum)->matchstr('^\w\+\ze\t')
    if word->hlexists()
      var type = 'help-hl-' .. word
      if prop_type_list({bufnr: buf})->index(type) != -1
	# was called before, delete existing properties
	prop_remove({type: type, bufnr: buf})
	prop_type_delete(type, {bufnr: buf})
      endif
      prop_type_add(type, {
	bufnr: buf,
	highlight: word,
	combine: false,
	})
      prop_add(lnum, 1, {length: word->strlen(), type: type})
    endif
  endfor

  setpos('.', save_cursor)
enddef