patch 9.0.1960: Make CI checks more strict Commit: https://github.com/vim/vim/commit/f7f746b1672909ae57d2eec97253d6627f6c0887 Author: Yee Cheng Chin <ychin.git@gmail.com> Date: Sat Sep 30 12:28:50 2023 +0200 patch 9.0.1960: Make CI checks more strict Problem: Make CI checks more strict Solution: Add -Wstrict-prototypes -Wmissing-prototypes to CI, fix uncovered problems Add -Wstrict-prototypes -Wmissing-prototypes warnings check to CI Add two new warnings to CI, silence some Perl related build-warnings: - `strict-prototypes` helps prevent declaring a function with an empty argument list, e.g. `int func()`. In C++, that's equivalent to `int func(void)`, but in C, that means a function that can take any number of arguments which is rarely what we want. - `missing-prototypes` makes sure we use `static` for file-only internal functions. Non-static functions should have been declared on a prototype file. - Add `no-compound-token-split-by-macro` to the perl cflags, since it throws out a bunch of perl-related warnings that make the CI log unnecessary verbose and hard to read. This seems to happen only with clang 12 and above. When applying those changes, it already uncovered a few warnings, so fix up the code as well (fix prototypes, make the code static, remove shadowed var declaration) GTK header needs to have #pragma warning suppressiong because GTK2 headers will warn on `-Wstrict-prototypes`, and it's included by gui.h and so we can't just turn off the warning in a couple files. closes: #13223 closes: #13226 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>

/* XPM */
static char * tb_open_xpm[] = {
/* width height ncolors cpp [x_hot y_hot] */
"18 18 7 1 0 0",
/* colors */
" 	s none	m none	c none",
".	s iconColor1	m black	c #000000",
"X	s bottomShadowColor	m black	c #5D6069",
"o	s iconColor2	m none	c #FFFFFF",
"O	s iconGray1	m none	c #dedede",
"+	s iconGray5	m black	c #737373",
"@	s iconGray3	m none	c #adadad",
/* pixels */
"                  ",
"    .........X    ",
"    .oooooo.o.X   ",
"    .oooooo.oo.X  ",
"    .oooooo....X  ",
"  ...ooooooooo... ",
"  .O.OOOOOOOOo.+. ",
".............O.+.X",
".oooooooooooo..+.X",
" .o@@@@@@@@@@+.+.X",
" .o@@@@@@@@@@@.+.X",
"  .o@@@@@@@@@@+..X",
"  .o@@@@@@@@@@@..X",
"   .o+++++++++++.X",
"   ..............X",
"     XXXXXXXXXXXXX",
"                  ",
"                  "};