Mercurial > vim
view src/osdef2.h.in @ 32876:522f16e3e058 v9.0.1747
patch 9.0.1747: screenpos() may cause unnecessary redraw
Commit: https://github.com/vim/vim/commit/6235a109c48ff2559eca3b16578c429ffb61eadc
Author: zeertzjq <zeertzjq@outlook.com>
Date: Sat Aug 19 14:12:42 2023 +0200
patch 9.0.1747: screenpos() may cause unnecessary redraw
Problem: screenpos() may cause unnecessary redraw.
Solution: Don't unnecessarily reset VALID_WROW flag.
VALID_WROW flag is only used by two functions: validate_cursor() and
cursor_valid(), and cursor_valid() is only used once in ex_sleep().
When adjust_plines_for_skipcol() was first added in patch 9.0.0640, it
was called in two functions: comp_botline() and curs_rows().
- comp_botline() is called in two places:
- onepage(), which resets VALID_WROW flag immediately afterwards.
- validate_botline_win(), where resetting a VALID_ flag is strange.
- curs_rows() is called in two places:
- curs_columns(), which sets VALID_WROW flag afterwards.
- validate_cline_row(), which is only used by GUI mouse focus.
Therefore resetting VALID_WROW there doesn't seem to do anything useful.
Also, a w_skipcol check (which resets VALID_WROW flag) was added to
check_cursor_moved() in patch 9.0.0734, which seems to make more sense
than resetting that flag in the middle of a computation.
While at it make adjust_plines_for_skipcol() and textpos2screenpos() a
bit less confusing:
- Make adjust_plines_for_skipcol() return "off" instead of "n - off".
- Use 0-based "row" in textpos2screenpos() until W_WINROW is added.
closes: #12832
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sat, 19 Aug 2023 14:30:02 +0200 |
parents | 9f3fd7937957 |
children |
line wrap: on
line source
/* * osdef2.h.in - See osdef1.h.in for a description. */ extern int remove(const char *); extern int rename(const char *, const char *); extern int free(char *); extern char *malloc(unsigned int); extern char *realloc(char *, int); extern char *getenv(char *); #ifndef __TANDEM extern int setenv(char *, char *, int); #else extern int setenv(const char *, const char *, int); #endif extern int putenv(const char *); #ifndef __TANDEM extern int gethostname(char *, int); #endif extern void perror(char *); #ifndef __TANDEM extern int sleep(int); #endif extern int usleep(unsigned int); extern unsigned int alarm(unsigned int); #ifndef __TANDEM extern int chdir(char *); #endif extern int fchdir(int); #ifndef stat /* could be redefined to stat64() */ extern int stat(const char *, struct stat *); #endif #ifndef lstat /* could be redefined to lstat64() */ extern int lstat(const char *, struct stat *); #endif extern int fstat(int, struct stat *); extern int open(const char *, int, ...); extern int close(int); #ifndef __TANDEM extern int read(int, char *, size_t); extern int write(int, char *, size_t); #endif extern int pipe(int *); extern off_t lseek(int, off_t, int); extern void sync(void); extern uid_t getuid(void); extern gid_t getgid(void); extern void qsort(void *, size_t, size_t, int (*)(const void *, const void *)); extern int isatty(int); extern int getpid(void); extern int dup(int); extern int unlink(const char *); extern int link(const char *, const char *); extern int mkdir(const char *, mode_t); extern int rmdir(const char *); extern int tgetent(char *, char *); extern int tgetnum(char *); extern int tgetflag(char *); extern char *tgoto(char *, int, int); extern int tputs(char *, int, int (*)(int)); #ifdef HAVE_TERMIOS_H struct termios; /* for tcgetattr() */ extern int tcgetattr(int, struct termios *); extern int tcsetattr(int, int, const struct termios *); #endif #ifdef HAVE_SYS_STATFS_H struct statfs; /* for fstatfs() */ extern int fstatfs(int, struct statfs *, int, int); #endif #ifdef HAVE_GETTIMEOFDAY struct timeval; /* for gettimeofday() */ struct timezone; /* for gettimeofday() */ extern int gettimeofday(struct timeval *tp, struct timezone *tzp); extern time_t time(time_t *); #endif #ifdef HAVE_GETPWNAM struct passwd; /* for getpwnam() */ extern struct passwd *getpwnam(const char *); #endif #ifdef USE_TMPNAM extern char *tmpnam(char *); #else extern char *mktemp(char *); #endif #ifdef ISC extern int _Xmblen(char const *, size_t); #else /* This is different from the header but matches mblen() */ extern int _Xmblen(char *, size_t); #endif