view ci/unlisted.make @ 34684:faf891660963 v9.1.0223

patch 9.1.0223: code duplication in loop to add active text properties Commit: https://github.com/vim/vim/commit/1134fdd1b369119d0d6992e3120bb5f7c788b697 Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Date: Thu Mar 28 11:49:46 2024 +0100 patch 9.1.0223: code duplication in loop to add active text properties Problem: There are two dense conditions with duplication that needs to be kept in sync between the while loop break condition and the condition to skip certain text properties. Solution: Refactor the loop by moving while loop conditions into the body of the while loop so they can be shared with skip conditions. `break` and an `active` variable are used to handle the outcome of these merged conditions. (Dylan Thacker-Smith) closes: #14307 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 28 Mar 2024 12:00:05 +0100
parents e6c291944e18
children
line wrap: on
line source

# vim: ft=make
SHELL = /bin/bash

# List all files that are tracked in git but not listed in Filelist.
# Exit code is 2 ("Make encountered an error") if any such files exist.

# Filelist is a Makefile that defines many variables, so we use Make itself to
# query which variables it defines, then expand them all by wrapping each name
# in $(...), importing Filelist and using $(eval).

include Filelist
$(eval all_patterns := $(shell \
	make -f Filelist --question --print-data-base --no-builtin-rules \
		--no-builtin-variables 2>/dev/null \
	| sed -nre \
		'/^# makefile .from \x27Filelist\x27,/ { \
			n; \
			s/ = .*//; \
			T; \
			s/.*/$$(\0)/; \
			p; \
		}'))

# In Makefile's `prepeare` target, all the IN_README_DIR files are moved from
# READMEdir to the root, so add those files in their Git-tracked location:
all_patterns := $(all_patterns) \
	$(foreach readme, $(IN_README_DIR), READMEdir/$(readme))

# The result 'all_patterns' is a list of patterns (globs), which we expand with
# wildcard to get actual filenames.  Note this means Filelist can list a file
# that does not exist, and it will be omitted at this step.
listed_files := $(wildcard $(all_patterns))

# Default target to actually run the comparison:
.PHONY: check
check:
	@# There are too many files to list on the command line, so we write
	@# that to a temporary file, one per line.
	$(file > Filelist-listed-files)
	$(foreach filename, $(listed_files),\
		$(file >> Filelist-listed-files,$(filename)))
	@# Compare the sorted lists.  Delete that temporary file on both
	@# success and failure, but exit with diff's exit code.
	diff -u0 --label files-in-git <(git ls-files | sort) \
		--label Filelist <(sort --unique Filelist-listed-files); \
	RV=$$?; \
	rm Filelist-listed-files; \
	(($$RV != 0)) && echo "Add files to the right variable in Filelist."; \
	exit $$RV