Mercurial > vim
view src/Make_ming.mak @ 34309:d7cfd8fb1d75 v9.1.0089
patch 9.1.0089: qsort() comparison functions should be transitive
Commit: https://github.com/vim/vim/commit/e06e43766500ecb4cd1031fa16cf9cbebdb222c1
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Feb 9 19:39:14 2024 +0100
patch 9.1.0089: qsort() comparison functions should be transitive
Problem: qsort() comparison functions should be transitive
Solution: Do not subtract values, but rather use explicit comparisons
Improve qsort() comparison functions
There has been a recent report on qsort() causing out-of-bounds read &
write in glibc for non transitive comparison functions
https://www.qualys.com/2024/01/30/qsort.txt
Even so the bug is in glibc's implementation of the qsort() algorithm,
it's bad style to just use substraction for the comparison functions,
which may cause overflow issues and as hinted at in OpenBSD's manual
page for qsort(): "It is almost always an error to use subtraction to
compute the return value of the comparison function."
So check the qsort() comparison functions and change them to be safe.
closes: #13980
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 09 Feb 2024 19:45:06 +0100 |
parents | 626fb8e8bb8a |
children |
line wrap: on
line source
# # Makefile for VIM on Win32, using MinGW # # Also read INSTALLpc.txt! # # The old Make_ming.mak (maintained by Ron Aaron et al.) was merged into # Make_cyg_ming.mak. # This file contains MinGW specific settings. Common settings are contained # in Make_cyg_ming.mak. # # Last updated by Ken Takata. # Last Change: 2014 Oct 21 # uncomment 'PERL' if you want a perl-enabled version #PERL=c:/perl # uncomment 'LUA' if you want a Lua-enabled version #LUA=c:/lua # uncomment 'MZSCHEME' if you want a MzScheme-enabled version #MZSCHEME=d:/plt # uncomment 'PYTHON' if you want a python-enabled version # Put the path to the python distro here. If cross compiling from Linux, you # will also need to convert the header files to unix instead of dos format: # for fil in *.h ; do vim -e -c 'set ff=unix|w|q' $fil # and also, you will need to make a mingw32 'libpython20.a' to link with: # cd $PYTHON/libs # pexports python20.dll > python20.def # dlltool -d python20.def -l libpython20.a # on my Linux box, I put the Python stuff here: #PYTHON=/home/ron/ActivePython-2.0.0-202/src/Core # on my NT box, it's here: #PYTHON=c:/python20 # uncomment 'PYTHON3' if you want a python3-enabled version #PYTHON3=c:/python31 # uncomment 'TCL' if you want a Tcl-enabled version #TCL=c:/tcl # uncomment 'RUBY' if you want a Ruby-enabled version #RUBY=c:/ruby # Do not change this. UNDER_CYGWIN = no include Make_cyg_ming.mak # vim: set noet sw=8 ts=8 sts=0 wm=0 tw=0: