Mercurial > vim
view src/INSTALLmac.txt @ 34309:d7cfd8fb1d75 v9.1.0089
patch 9.1.0089: qsort() comparison functions should be transitive
Commit: https://github.com/vim/vim/commit/e06e43766500ecb4cd1031fa16cf9cbebdb222c1
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Feb 9 19:39:14 2024 +0100
patch 9.1.0089: qsort() comparison functions should be transitive
Problem: qsort() comparison functions should be transitive
Solution: Do not subtract values, but rather use explicit comparisons
Improve qsort() comparison functions
There has been a recent report on qsort() causing out-of-bounds read &
write in glibc for non transitive comparison functions
https://www.qualys.com/2024/01/30/qsort.txt
Even so the bug is in glibc's implementation of the qsort() algorithm,
it's bad style to just use substraction for the comparison functions,
which may cause overflow issues and as hinted at in OpenBSD's manual
page for qsort(): "It is almost always an error to use subtraction to
compute the return value of the comparison function."
So check the qsort() comparison functions and change them to be safe.
closes: #13980
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 09 Feb 2024 19:45:06 +0100 |
parents | 695b50472e85 |
children |
line wrap: on
line source
INSTALLmac.txt - Installation of Vim on Apple MacOS This file contains instructions for compiling Vim. If you already have an executable version of Vim, you don't need this. MacOS Classic is no longer supported. If you really want it use Vim 6.4. Only '/' is supported as path separator. ---------------------------------------------------------------------------- Prerequisites ---------------------------------------------------------------------------- Make sure you've installed Xcode and CommandLineTools. You can download Xcode from the Mac App Store, for free. To check for CommandLineTools open a terminal and do: $ make --version If not installed yet a window pops up instructing you to install the developer tools. If you don't have the source yet, best is to use git (which you need to install first), see http://www.vim.org/git.php Or you can download and unpack the Unix tar archive, see http://www.vim.org/download.php ---------------------------------------------------------------------------- Build and install the terminal version. ---------------------------------------------------------------------------- You can compile vim with the standard Unix routine: cd vim/src make make test sudo make install If you get an error "glibtool: command not found" search on stackoverflow for mac-osx-where-can-i-download-glibtool. With Homebrew, run: brew install libtool To build libtool from source: 1. Download the source code from https://www.gnu.org/software/libtool/. 2. Run these commands from the root of the source code directory: ./configure --program-prefix=g make sudo make install ---------------------------------------------------------------------------- Build and install the GUI version with X-Windows ---------------------------------------------------------------------------- NOTE: this probably no longer works, since Athena support has been removed. First, install XQuartz, which you can download from https://www.xquartz.org. To tell configure to use a GUI you can edit the Makefile and uncomment these two lines (remove the # at the start of the line): CONF_OPT_GUI = --enable-gui=athena CONF_OPT_DARWIN = --disable-darwin Do "make distclean" to start with a clean slate. Then build as with the terminal version above. Instead of "athena" you can try "gtk2" but you probably need to install GTK first. ---------------------------------------------------------------------------- Notes ---------------------------------------------------------------------------- Mac-specific configure options are explained in the Makefile: --disable-darwin --with-mac-arch