Mercurial > vim
view .appveyor.yml @ 36242:b2a5d49fcedb
runtime(comment): consider &tabstop in lines after whitespace indent
Commit: https://github.com/vim/vim/commit/7b27fc49a8c4ce480f759dc33082e6150fb94238
Author: Konfekt <Konfekt@users.noreply.github.com>
Date: Sat Oct 5 16:17:04 2024 +0200
runtime(comment): consider &tabstop in lines after whitespace indent
The count `strlen()` in
```vim
line = printf(indent_start .. substitute(cms, '%s\@!', '%%', 'g'),
strpart(getline(lnum), strlen(indent_start)))
```
is too large if the block of lines to be operated on contains different
whitespace indenting (tab vs. spaces).
Considering using `2gcc` on the first line with 4 spaces as indenting
and on the next line using a single tab character (with &tabstop value
of 8):
Using `strlen(indent_start) = 4` for an initial indent of 4 spaces is
correct for the first line, but wrong for the next line and will
therefore wrongly comment out the tab-indented line (and possibly
deleting some content).
The new check is still too simple because it assumes that as soon as
there's a tab the whole indent is made of tabs; it's a start of entering
the mixed tab and whitespace indent rabbit hole.
fixes: #15797
closes: #15805
Signed-off-by: Konfekt <Konfekt@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sat, 05 Oct 2024 16:30:07 +0200 |
parents | 93c715c63a4a |
children |
line wrap: on
line source
version: "{build}" image: Visual Studio 2015 skip_tags: true environment: matrix: - FEATURE: HUGE # Alternate environments, not used right now. 2022 is a lot slower. # # - job_name: VS-2015 # appveyor_build_worker_image: Visual Studio 2015 # FEATURE: HUGE # - job_name: VS-2017 # appveyor_build_worker_image: Visual Studio 2017 # FEATURE: HUGE # - job_name: VS-2019 # appveyor_build_worker_image: Visual Studio 2019 # FEATURE: HUGE # - job_name: VS-2022 # appveyor_build_worker_image: Visual Studio 2022 # FEATURE: HUGE # disabled # - FEATURE: TINY # - FEATURE: NORMAL matrix: fast_finish: true before_build: - call ver - ci\appveyor.bat install build_script: - ci\appveyor.bat build test_script: - ci\appveyor.bat test artifacts: - path: src/vim.exe name: vim - path: src/gvim.exe name: gvim # vim: sw=2 sts=2 et ts=8 sr