Mercurial > vim
view src/msvc-latest.bat @ 33420:aa7cd2253130 v9.0.1968
patch 9.0.1968: cmdline completion should consider key option
Commit: https://github.com/vim/vim/commit/6ee7b521fa7531ef356ececc8be7575c3800f872
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Sun Oct 1 09:13:22 2023 +0200
patch 9.0.1968: cmdline completion should consider key option
Problem: cmdline completion should consider key option
Solution: Disable cmdline completion for key option, slightly
refactor how P_NO_CMD_EXPAND is handled
Harden crypto 'key' option: turn off cmdline completion, disable set-=
"set-=" can be used maliciously with a crypto key, as it allows an
attacker (who either has access to the computer or a plugin author) to
guess a substring by observing the modified state. Simply turn off
set+=/-=/^= for this option as there is no good reason for them to be
used.
Update docs to make that clear as well.
Also, don't allow cmdline completion for 'key' as it just shows *****
which is not useful and confusing to the user what it means (if the user
accidentally hits enter they will have replaced their key with "*****"
instead).
Move logic to better location, don't use above 32-bit for flags
Move P_NO_CMD_EXPAND to use the unused 0x20 instead of going above
32-bits, as currently the flags parameter is only 32-bits on some
systems. Left a comment to warn that future additions will need to
change how the flags work either by making it 64-bit or split into two
member vars.
Also, move the logic for detecting P_NO_CMD_EXPAND earlier so it's not
up to each handler to decide, and you won't see the temporary "..." that
Vim shows while waiting for completion handler to complete.
closes: #13224
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 01 Oct 2023 09:30:03 +0200 |
parents | 54dda39c5bb3 |
children |
line wrap: on
line source
@echo off rem To be used on MS-Windows for Visual C++ 2017 or later. rem See INSTALLpc.txt for information. rem rem Usage: rem For x86 builds run this with "x86" option: rem msvc-latest x86 rem For x64 builds run this with "x86_amd64" option or "x64" option: rem msvc-latest x86_amd64 rem msvc-latest x64 rem rem Optional environment variables: rem VSWHERE: rem Full path to vswhere.exe. rem VSVEROPT: rem Option to search specific version of Visual Studio. rem Default: -latest rem To search VS2017: rem set "VSVEROPT=-version [15.0^,16.0^)" rem To search VS2019: rem set "VSVEROPT=-version [16.0^,17.0^)" rem To search VS2022: rem set "VSVEROPT=-version [17.0^,18.0^)" if "%VSWHERE%"=="" ( set "VSWHERE=%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" set VSWHERE_SET=yes ) if not exist "%VSWHERE%" ( echo Error: vswhere not found. set VSWHERE= set VSWHERE_SET= exit /b 1 ) if "%VSVEROPT%"=="" ( set VSVEROPT=-latest set VSVEROPT_SET=yes ) rem Search Visual Studio Community, Professional or above. for /f "usebackq tokens=*" %%i in (`"%VSWHERE%" %VSVEROPT% -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do ( set InstallDir=%%i ) if exist "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" ( call "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" %* goto done ) rem Search Visual Studio 2017 Express. rem (Visual Studio 2017 Express uses different component IDs.) for /f "usebackq tokens=*" %%i in (`"%VSWHERE%" %VSVEROPT% -products Microsoft.VisualStudio.Product.WDExpress -property installationPath`) do ( set InstallDir=%%i ) if exist "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" ( call "%InstallDir%\VC\Auxiliary\Build\vcvarsall.bat" %* ) else ( echo Error: vcvarsall.bat not found. rem Set ERRORLEVEL to 1. call ) :done if "%VSWHERE_SET%"=="yes" ( set VSWHERE= set VSWHERE_SET= ) if "%VSVEROPT_SET%"=="yes" ( set VSVEROPT= set VSVEROPT_SET= ) set InstallDir=