Mercurial > vim
view src/gui_haiku.h @ 33420:aa7cd2253130 v9.0.1968
patch 9.0.1968: cmdline completion should consider key option
Commit: https://github.com/vim/vim/commit/6ee7b521fa7531ef356ececc8be7575c3800f872
Author: Yee Cheng Chin <ychin.git@gmail.com>
Date: Sun Oct 1 09:13:22 2023 +0200
patch 9.0.1968: cmdline completion should consider key option
Problem: cmdline completion should consider key option
Solution: Disable cmdline completion for key option, slightly
refactor how P_NO_CMD_EXPAND is handled
Harden crypto 'key' option: turn off cmdline completion, disable set-=
"set-=" can be used maliciously with a crypto key, as it allows an
attacker (who either has access to the computer or a plugin author) to
guess a substring by observing the modified state. Simply turn off
set+=/-=/^= for this option as there is no good reason for them to be
used.
Update docs to make that clear as well.
Also, don't allow cmdline completion for 'key' as it just shows *****
which is not useful and confusing to the user what it means (if the user
accidentally hits enter they will have replaced their key with "*****"
instead).
Move logic to better location, don't use above 32-bit for flags
Move P_NO_CMD_EXPAND to use the unused 0x20 instead of going above
32-bits, as currently the flags parameter is only 32-bits on some
systems. Left a comment to warn that future additions will need to
change how the flags work either by making it 64-bit or split into two
member vars.
Also, move the logic for detecting P_NO_CMD_EXPAND earlier so it's not
up to each handler to decide, and you won't see the temporary "..." that
Vim shows while waiting for completion handler to complete.
closes: #13224
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 01 Oct 2023 09:30:03 +0200 |
parents | 22f0dda71638 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4: * * VIM - Vi IMproved by Bram Moolenaar * GUI support by Olaf "Rhialto" Seibert * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * * Haiku GUI. * * Based on "GUI support for the Buzzword Enhanced Operating System for PPC." * */ /* * This file must be acceptable both as C and C++. * The BeOS API is defined in terms of C++, but some classes * should be somewhat known in the common C code. */ // System classes struct BMenu; struct BMenuItem; struct BPictureButton; // Our own Vim-related classes struct VimApp; struct VimFormView; struct VimTextAreaView; struct VimWindow; struct VimScrollBar; // Locking functions extern int vim_lock_screen(); extern void vim_unlock_screen(); #ifndef __cplusplus typedef struct BMenu BMenu; typedef struct BMenuItem BMenuItem; typedef struct BPictureButton BPictureButton; typedef struct VimWindow VimWindow; typedef struct VimFormView VimFormView; typedef struct VimTextAreaView VimTextAreaView; typedef struct VimApp VimApp; typedef struct VimScrollBar VimScrollBar; #endif