Mercurial > vim
view src/gui_xmebwp.h @ 33865:8cdb69ea3711 v9.0.2143
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Commit: https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 30 11:32:18 2023 +0100
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: #13596
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:05 +0100 |
parents | 6e3dc2d630c2 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * * (C) 2002,2005 by Marcin Dalecki <martin@dalecki.de> * * MARCIN DALECKI ASSUMES NO RESPONSIBILITY FOR THE USE OR INABILITY TO USE ANY * OF THIS SOFTWARE . THIS SOFTWARE IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY * KIND, AND MARCIN DALECKI EXPRESSLY DISCLAIMS ALL IMPLIED WARRANTIES, * INCLUDING BUT NOT LIMITED TO THE IMPLIED WARRANTIES OF MERCHANTABILITY AND * FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef EnhancedBP_H #define EnhancedBP_H #include <Xm/PushBP.h> #include "gui_xmebw.h" /* * EnhancedButton class structure. */ typedef struct _XmEnhancedButtonClassPart { Pixmap stipple_bitmap; } XmEnhancedButtonClassPart; /* * Full class record declaration for EnhancedButton class. */ typedef struct { CoreClassPart core_class; XmPrimitiveClassPart primitive_class; XmLabelClassPart label_class; XmPushButtonClassPart pushbutton_class; XmEnhancedButtonClassPart enhancedbutton_class; } XmEnhancedButtonClassRec; extern XmEnhancedButtonClassRec xmEnhancedButtonClassRec; /* * EnhancedButton instance record. */ typedef struct _XmEnhancedButtonPart { // public resources String pixmap_data; String pixmap_file; Dimension spacing; int label_location; // private resources int pixmap_depth; Dimension pixmap_width; Dimension pixmap_height; Pixmap normal_pixmap; Pixmap armed_pixmap; Pixmap insensitive_pixmap; Pixmap highlight_pixmap; int doing_setvalues; int doing_destroy; } XmEnhancedButtonPart; /* * Full instance record declaration. */ typedef struct _XmEnhancedButtonRec { CorePart core; XmPrimitivePart primitive; XmLabelPart label; XmPushButtonPart pushbutton; XmEnhancedButtonPart enhancedbutton; } XmEnhancedButtonRec; #endif