Mercurial > vim
view src/xdiff/README.txt @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | f84e5db372ea |
children |
line wrap: on
line source
The files in this directory come from the xdiff implementation in git. You can find it here: https://github.com/git/git/tree/master/xdiff The files were last updated March 17, 2023 from git release v.2.40.0 This is originally based on libxdiff, which can be found here: http://www.xmailserver.org/xdiff-lib.html The git version was used because it has been maintained and improved. And since it's part of git it is expected to be reliable. The code is distributed under the GNU LGPL license. It is included in the COPYING file. Changes in these files were made to avoid compiler warnings. The /* */ comments are kept to make syncing to a newer version easier, do not change them to // comments! The first work for including xdiff in Vim was done by Christian Brabandt.