Mercurial > vim
view src/proto/fold.pro @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Thu, 28 Mar 2024 12:15:03 +0100 |
| parents | 34639bba19b0 |
| children |
line wrap: on
line source
/* fold.c */ void copyFoldingState(win_T *wp_from, win_T *wp_to); int hasAnyFolding(win_T *win); int hasFolding(linenr_T lnum, linenr_T *firstp, linenr_T *lastp); int hasFoldingWin(win_T *win, linenr_T lnum, linenr_T *firstp, linenr_T *lastp, int cache, foldinfo_T *infop); int lineFolded(win_T *win, linenr_T lnum); long foldedCount(win_T *win, linenr_T lnum, foldinfo_T *infop); int foldmethodIsManual(win_T *wp); int foldmethodIsIndent(win_T *wp); int foldmethodIsExpr(win_T *wp); int foldmethodIsMarker(win_T *wp); int foldmethodIsSyntax(win_T *wp); int foldmethodIsDiff(win_T *wp); void closeFold(linenr_T lnum, long count); void closeFoldRecurse(linenr_T lnum); void opFoldRange(linenr_T first, linenr_T last, int opening, int recurse, int had_visual); void openFold(linenr_T lnum, long count); void openFoldRecurse(linenr_T lnum); void foldOpenCursor(void); void newFoldLevel(void); void foldCheckClose(void); int foldManualAllowed(int create); void foldCreate(linenr_T start, linenr_T end); void deleteFold(linenr_T start, linenr_T end, int recursive, int had_visual); void clearFolding(win_T *win); void foldUpdate(win_T *wp, linenr_T top, linenr_T bot); void foldUpdateAll(win_T *win); int foldMoveTo(int updown, int dir, long count); void foldInitWin(win_T *new_win); int find_wl_entry(win_T *win, linenr_T lnum); void foldAdjustVisual(void); void foldAdjustCursor(void); void cloneFoldGrowArray(garray_T *from, garray_T *to); void deleteFoldRecurse(garray_T *gap); void foldMarkAdjust(win_T *wp, linenr_T line1, linenr_T line2, long amount, long amount_after); int getDeepestNesting(void); char_u *get_foldtext(win_T *wp, linenr_T lnum, linenr_T lnume, foldinfo_T *foldinfo, char_u *buf); void foldMoveRange(garray_T *gap, linenr_T line1, linenr_T line2, linenr_T dest); int put_folds(FILE *fd, win_T *wp); void f_foldclosed(typval_T *argvars, typval_T *rettv); void f_foldclosedend(typval_T *argvars, typval_T *rettv); void f_foldlevel(typval_T *argvars, typval_T *rettv); void f_foldtext(typval_T *argvars, typval_T *rettv); void f_foldtextresult(typval_T *argvars, typval_T *rettv); /* vim: set ft=c : */