Mercurial > vim
view src/libvterm/CODE-MAP @ 33872:2c5ae1ce5af2 v9.0.2146
patch 9.0.2146: text-property without type errors when joining
Commit: https://github.com/vim/vim/commit/0d0b3b19517c321b089d637919e88e49a07a3d85
Author: Christian Brabandt <cb@256bit.org>
Date: Sun Dec 3 17:56:43 2023 +0100
patch 9.0.2146: text-property without type errors when joining
Problem: text-property without type errors when joining
Solution: count all text-properties, with or without type
before joining lines
Error when joining lines with text properties without a proper type
When joining lines, we need to consider all text properties that are
attached to a line, even when those text properties are invalid and do
not have a type attached to them.
However, since patch v9.0.0993
(commit: 89469d157aea01513bde826b4519dd6b5fbceae4)
those text properties won't be counted when joining lines and therefore
this will cause the adjustment for text properties on joining to go
wrong (and may later cause SIGABRT with an invalid free pointer)
I am not sure, why the condition to not count text properties with a
valid type was added in patch v9.0.993, because no test fails if those
condition is removed. So let's just remove this condition and add a test
that verifies, that we are able to join lines, even when the text
properties attached to it do not have a valid type.
fixes: #13609
closes: #13614
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:11 +0100 |
parents | b13f723a7ec6 |
children |
line wrap: on
line source
CODE-MAP - high-level list and description of files in the repository CONTRIBUTING - documentation explaining how developers can contribute fixes and features doc/ - contains documentation doc/seqs.txt - documents the sequences recognised by the library include/vterm.h - main include file include/vterm_keycodes.h - include file containing the keyboard input keycode enumerations LICENSE - legalese Makefile - main build file src/ - contains the source code for the library src/encoding.c - handles mapping ISO/IEC 2022 alternate character sets into Unicode codepoints src/keyboard.c - handles sending reported keyboard events to the output stream src/mouse.c - handles sending reported mouse events to the output stream src/parser.c - parses bytes from the input stream into parser-level events src/pen.c - interprets SGR sequences and maintains current rendering attributes src/screen.c - uses state-level events to maintain a buffer of current screen contents src/state.c - follows parser-level events to keep track of the overall terminal state src/unicode.c - utility functions for Unicode and UTF-8 handling src/vterm.c - toplevel object state and miscellaneous functions src/vterm_internal.h - include file for definitions private to the library's internals t/ - contains unit tests t/harness.c - standalone program to embed the library into for unit-test purposes t/run-test.pl - invokes the test harness to run a single unit test script