Mercurial > vim
view src/if_perlsfio.c @ 33862:242b964d6269 v9.0.2140
patch 9.0.2140: [security]: use-after-free in win-enter
Commit: https://github.com/vim/vim/commit/eec0c2b3a4cfab93dd8d4adaa60638d47a2bbc8a
Author: Christian Brabandt <cb@256bit.org>
Date: Tue Nov 28 22:03:48 2023 +0100
patch 9.0.2140: [security]: use-after-free in win-enter
Problem: [security]: use-after-free in win-enter
Solution: validate window pointer before calling win_enter()
win_goto() may stop visual mode, if it is active. However, this may in
turn trigger the ModeChanged autocommand, which could potentially free
the wp pointer which was valid before now became stale and points to now
freed memory.
So before calling win_enter(), let's verify one more time, that the
wp pointer still points to a valid window structure.
Reported by @henices, thanks!
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:01 +0100 |
parents | f0f9692d4487 |
children |
line wrap: on
line source
/* vi:set ts=8 sts=4 sw=4 noet: * * VIM - Vi IMproved by Bram Moolenaar * * Do ":help uganda" in Vim to read copying and usage conditions. * Do ":help credits" in Vim to see a list of people who contributed. * See README.txt for an overview of the Vim source code. */ /* * if_perlsfio.c: Special I/O functions for Perl interface. */ #define _memory_h // avoid memset redeclaration #define IN_PERL_FILE // don't include if_perl.pro from prot.h #include "vim.h" #if defined(USE_SFIO) || defined(PROTO) #ifndef USE_SFIO // just generating prototypes # define Sfio_t int # define Sfdisc_t int #endif #define NIL(type) ((type)0) static int sfvimwrite( Sfio_t *f, // stream involved char *buf, // buffer to read from int n, // number of bytes to write Sfdisc_t *disc) // discipline { char_u *str; str = vim_strnsave((char_u *)buf, n); if (str == NULL) return 0; msg_split((char *)str); vim_free(str); return n; } /* * sfdcnewnvi -- * Create Vim discipline */ Sfdisc_t * sfdcnewvim(void) { Sfdisc_t *disc; disc = ALLOC_ONE(Sfdisc_t); if (disc == NULL) return NULL; disc->readf = (Sfread_f)NULL; disc->writef = sfvimwrite; disc->seekf = (Sfseek_f)NULL; disc->exceptf = (Sfexcept_f)NULL; return disc; } #endif // USE_SFIO