Mercurial > vim
view src/testdir/test_termdebug.vim @ 33811:06219b3bdaf3 v9.0.2121
patch 9.0.2121: [security]: use-after-free in ex_substitute
Commit: https://github.com/vim/vim/commit/26c11c56888d01e298cd8044caf860f3c26f57bb
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 22 21:26:41 2023 +0100
patch 9.0.2121: [security]: use-after-free in ex_substitute
Problem: [security]: use-after-free in ex_substitute
Solution: always allocate memory
closes: #13552
A recursive :substitute command could cause a heap-use-after free in Vim
(CVE-2023-48706).
The whole reproducible test is a bit tricky, I can only reproduce this
reliably when no previous substitution command has been used yet
(which is the reason, the test needs to run as first one in the
test_substitute.vim file) and as a combination of the `:~` command
together with a :s command that contains the special substitution atom `~\=`
which will make use of a sub-replace special atom and calls a vim script
function.
There was a comment in the existing :s code, that already makes the
`sub` variable allocate memory so that a recursive :s call won't be able
to cause any issues here, so this was known as a potential problem
already. But for the current test-case that one does not work, because
the substitution does not start with `\=` but with `~\=` (and since
there does not yet exist a previous substitution atom, Vim will simply
increment the `sub` pointer (which then was not allocated dynamically)
and later one happily use a sub-replace special expression (which could
then free the `sub` var).
The following commit fixes this, by making the sub var always using
allocated memory, which also means we need to free the pointer whenever
we leave the function. Since sub is now always an allocated variable,
we also do no longer need the sub_copy variable anymore, since this one
was used to indicated when sub pointed to allocated memory (and had
therefore to be freed on exit) and when not.
Github Security Advisory:
https://github.com/vim/vim/security/advisories/GHSA-c8qm-x72m-q53q
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Wed, 22 Nov 2023 22:15:05 +0100 |
| parents | ffe9ffcb57e7 |
| children | 4cacac1abdb8 |
line wrap: on
line source
" Test for the termdebug plugin source shared.vim source check.vim CheckUnix CheckFeature terminal CheckExecutable gdb CheckExecutable gcc let g:GDB = exepath('gdb') if g:GDB->empty() throw 'Skipped: gdb is not found in $PATH' endif let g:GCC = exepath('gcc') if g:GCC->empty() throw 'Skipped: gcc is not found in $PATH' endif packadd termdebug func Test_termdebug_basic() let lines =<< trim END #include <stdio.h> #include <stdlib.h> int isprime(int n) { if (n <= 1) return 0; for (int i = 2; i <= n / 2; i++) if (n % i == 0) return 0; return 1; } int main(int argc, char *argv[]) { int n = 7; printf("%d is %s prime\n", n, isprime(n) ? "a" : "not a"); return 0; } END call writefile(lines, 'XTD_basic.c', 'D') call system($'{g:GCC} -g -o XTD_basic XTD_basic.c') edit XTD_basic.c Termdebug ./XTD_basic call WaitForAssert({-> assert_equal(3, winnr('$'))}) let gdb_buf = winbufnr(1) wincmd b Break 9 call term_wait(gdb_buf) redraw! call assert_equal([ \ {'lnum': 9, 'id': 1014, 'name': 'debugBreakpoint1.0', \ 'priority': 110, 'group': 'TermDebug'}], \ sign_getplaced('', #{group: 'TermDebug'})[0].signs) Run call term_wait(gdb_buf, 400) redraw! call WaitForAssert({-> assert_equal([ \ {'lnum': 9, 'id': 12, 'name': 'debugPC', 'priority': 110, \ 'group': 'TermDebug'}, \ {'lnum': 9, 'id': 1014, 'name': 'debugBreakpoint1.0', \ 'priority': 110, 'group': 'TermDebug'}], \ sign_getplaced('', #{group: 'TermDebug'})[0].signs)}) Finish call term_wait(gdb_buf) redraw! call WaitForAssert({-> assert_equal([ \ {'lnum': 9, 'id': 1014, 'name': 'debugBreakpoint1.0', \ 'priority': 110, 'group': 'TermDebug'}, \ {'lnum': 20, 'id': 12, 'name': 'debugPC', \ 'priority': 110, 'group': 'TermDebug'}], \ sign_getplaced('', #{group: 'TermDebug'})[0].signs)}) Continue call term_wait(gdb_buf) let i = 2 while i <= 258 Break call term_wait(gdb_buf) if i == 2 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint2.0')[0].text, '02')}) endif if i == 10 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint10.0')[0].text, '0A')}) endif if i == 168 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint168.0')[0].text, 'A8')}) endif if i == 255 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint255.0')[0].text, 'FF')}) endif if i == 256 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint256.0')[0].text, 'F+')}) endif if i == 258 call WaitForAssert({-> assert_equal(sign_getdefined('debugBreakpoint258.0')[0].text, 'F+')}) endif let i += 1 endwhile let cn = 0 " 60 is approx spaceBuffer * 3 if winwidth(0) <= 78 + 60 Var call assert_equal(winnr(), winnr('$')) call assert_equal(winlayout(), ['col', [['leaf', 1002], ['leaf', 1001], ['leaf', 1000], ['leaf', 1003 + cn]]]) let cn += 1 bw! Asm call assert_equal(winnr(), winnr('$')) call assert_equal(winlayout(), ['col', [['leaf', 1002], ['leaf', 1001], ['leaf', 1000], ['leaf', 1003 + cn]]]) let cn += 1 bw! endif set columns=160 call term_wait(gdb_buf) let winw = winwidth(0) Var if winwidth(0) < winw call assert_equal(winnr(), winnr('$') - 1) call assert_equal(winlayout(), ['col', [['leaf', 1002], ['leaf', 1001], ['row', [['leaf', 1003 + cn], ['leaf', 1000]]]]]) let cn += 1 bw! endif let winw = winwidth(0) Asm if winwidth(0) < winw call assert_equal(winnr(), winnr('$') - 1) call assert_equal(winlayout(), ['col', [['leaf', 1002], ['leaf', 1001], ['row', [['leaf', 1003 + cn], ['leaf', 1000]]]]]) let cn += 1 bw! endif set columns& call term_wait(gdb_buf) wincmd t quit! redraw! call WaitForAssert({-> assert_equal(1, winnr('$'))}) call assert_equal([], sign_getplaced('', #{group: 'TermDebug'})[0].signs) call delete('XTD_basic') %bw! endfunc func Test_termdebug_mapping() %bw! call assert_equal(maparg('K', 'n', 0, 1)->empty(), 1) call assert_equal(maparg('-', 'n', 0, 1)->empty(), 1) call assert_equal(maparg('+', 'n', 0, 1)->empty(), 1) Termdebug call WaitForAssert({-> assert_equal(3, winnr('$'))}) wincmd b call assert_equal(maparg('K', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('-', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('+', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('K', 'n', 0, 1).buffer, 0) call assert_equal(maparg('-', 'n', 0, 1).buffer, 0) call assert_equal(maparg('+', 'n', 0, 1).buffer, 0) call assert_equal(maparg('K', 'n', 0, 1).rhs, ':Evaluate<CR>') wincmd t quit! redraw! call WaitForAssert({-> assert_equal(1, winnr('$'))}) call assert_equal(maparg('K', 'n', 0, 1)->empty(), 1) call assert_equal(maparg('-', 'n', 0, 1)->empty(), 1) call assert_equal(maparg('+', 'n', 0, 1)->empty(), 1) %bw! nnoremap K :echom "K"<cr> nnoremap - :echom "-"<cr> nnoremap + :echom "+"<cr> Termdebug call WaitForAssert({-> assert_equal(3, winnr('$'))}) wincmd b call assert_equal(maparg('K', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('-', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('+', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('K', 'n', 0, 1).buffer, 0) call assert_equal(maparg('-', 'n', 0, 1).buffer, 0) call assert_equal(maparg('+', 'n', 0, 1).buffer, 0) call assert_equal(maparg('K', 'n', 0, 1).rhs, ':Evaluate<CR>') wincmd t quit! redraw! call WaitForAssert({-> assert_equal(1, winnr('$'))}) call assert_equal(maparg('K', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('-', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('+', 'n', 0, 1)->empty(), 0) call assert_equal(maparg('K', 'n', 0, 1).buffer, 0) call assert_equal(maparg('-', 'n', 0, 1).buffer, 0) call assert_equal(maparg('+', 'n', 0, 1).buffer, 0) call assert_equal(maparg('K', 'n', 0, 1).rhs, ':echom "K"<cr>') %bw! nnoremap <buffer> K :echom "bK"<cr> nnoremap <buffer> - :echom "b-"<cr> nnoremap <buffer> + :echom "b+"<cr> Termdebug call WaitForAssert({-> assert_equal(3, winnr('$'))}) wincmd b call assert_equal(maparg('K', 'n', 0, 1).buffer, 1) call assert_equal(maparg('-', 'n', 0, 1).buffer, 1) call assert_equal(maparg('+', 'n', 0, 1).buffer, 1) call assert_equal(maparg('K', 'n', 0, 1).rhs, ':echom "bK"<cr>') wincmd t quit! redraw! call WaitForAssert({-> assert_equal(1, winnr('$'))}) call assert_equal(maparg('K', 'n', 0, 1).buffer, 1) call assert_equal(maparg('-', 'n', 0, 1).buffer, 1) call assert_equal(maparg('+', 'n', 0, 1).buffer, 1) call assert_equal(maparg('K', 'n', 0, 1).rhs, ':echom "bK"<cr>') %bw! endfunc " vim: shiftwidth=2 sts=2 expandtab