Mercurial > vim
view src/testdir/test_restricted.vim @ 33811:06219b3bdaf3 v9.0.2121
patch 9.0.2121: [security]: use-after-free in ex_substitute
Commit: https://github.com/vim/vim/commit/26c11c56888d01e298cd8044caf860f3c26f57bb
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 22 21:26:41 2023 +0100
patch 9.0.2121: [security]: use-after-free in ex_substitute
Problem: [security]: use-after-free in ex_substitute
Solution: always allocate memory
closes: #13552
A recursive :substitute command could cause a heap-use-after free in Vim
(CVE-2023-48706).
The whole reproducible test is a bit tricky, I can only reproduce this
reliably when no previous substitution command has been used yet
(which is the reason, the test needs to run as first one in the
test_substitute.vim file) and as a combination of the `:~` command
together with a :s command that contains the special substitution atom `~\=`
which will make use of a sub-replace special atom and calls a vim script
function.
There was a comment in the existing :s code, that already makes the
`sub` variable allocate memory so that a recursive :s call won't be able
to cause any issues here, so this was known as a potential problem
already. But for the current test-case that one does not work, because
the substitution does not start with `\=` but with `~\=` (and since
there does not yet exist a previous substitution atom, Vim will simply
increment the `sub` pointer (which then was not allocated dynamically)
and later one happily use a sub-replace special expression (which could
then free the `sub` var).
The following commit fixes this, by making the sub var always using
allocated memory, which also means we need to free the pointer whenever
we leave the function. Since sub is now always an allocated variable,
we also do no longer need the sub_copy variable anymore, since this one
was used to indicated when sub pointed to allocated memory (and had
therefore to be freed on exit) and when not.
Github Security Advisory:
https://github.com/vim/vim/security/advisories/GHSA-c8qm-x72m-q53q
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Wed, 22 Nov 2023 22:15:05 +0100 |
| parents | de319bf98a39 |
| children |
line wrap: on
line source
" Test for "rvim" or "vim -Z" source shared.vim "if has('win32') && has('gui') " " Win32 GUI shows a dialog instead of displaying the error in the last line. " finish "endif func Test_restricted_mode() let lines =<< trim END if has('lua') call assert_fails('lua print("Hello, Vim!")', 'E981:') call assert_fails('luado return "hello"', 'E981:') call assert_fails('luafile somefile', 'E981:') call assert_fails('call luaeval("expression")', 'E145:') endif if has('mzscheme') call assert_fails('mzscheme statement', 'E981:') call assert_fails('mzfile somefile', 'E981:') call assert_fails('call mzeval("expression")', 'E145:') endif if has('perl') " TODO: how to make Safe mode fail? " call assert_fails('perl system("ls")', 'E981:') " call assert_fails('perldo system("hello")', 'E981:') " call assert_fails('perlfile somefile', 'E981:') " call assert_fails('call perleval("system(\"ls\")")', 'E145:') endif if has('python') call assert_fails('python print "hello"', 'E981:') call assert_fails('pydo return "hello"', 'E981:') call assert_fails('pyfile somefile', 'E981:') call assert_fails('call pyeval("expression")', 'E145:') endif if has('python3') call assert_fails('py3 print "hello"', 'E981:') call assert_fails('py3do return "hello"', 'E981:') call assert_fails('py3file somefile', 'E981:') call assert_fails('call py3eval("expression")', 'E145:') endif if has('ruby') call assert_fails('ruby print "Hello"', 'E981:') call assert_fails('rubydo print "Hello"', 'E981:') call assert_fails('rubyfile somefile', 'E981:') endif if has('tcl') call assert_fails('tcl puts "Hello"', 'E981:') call assert_fails('tcldo puts "Hello"', 'E981:') call assert_fails('tclfile somefile', 'E981:') endif if has('clientserver') call assert_fails('let s=remote_peek(10)', 'E145:') call assert_fails('let s=remote_read(10)', 'E145:') call assert_fails('let s=remote_send("vim", "abc")', 'E145:') call assert_fails('let s=server2client(10, "abc")', 'E145:') endif if has('terminal') call assert_fails('terminal', 'E145:') call assert_fails('call term_start("vim")', 'E145:') call assert_fails('call term_dumpwrite(1, "Xfile")', 'E145:') endif if has('channel') call assert_fails("call ch_logfile('Xlog')", 'E145:') call assert_fails("call ch_open('localhost:8765')", 'E145:') endif if has('job') call assert_fails("call job_start('vim')", 'E145:') endif if has('unix') && has('libcall') call assert_fails("echo libcall('libc.so', 'getenv', 'HOME')", 'E145:') endif call assert_fails("call rename('a', 'b')", 'E145:') call assert_fails("call delete('Xfile')", 'E145:') call assert_fails("call mkdir('Xdir')", 'E145:') call assert_fails('!ls', 'E145:') call assert_fails('shell', 'E145:') call assert_fails('stop', 'E145:') call assert_fails('exe "normal \<C-Z>"', 'E145:') set insertmode call assert_fails('call feedkeys("\<C-Z>", "xt")', 'E145:') set insertmode& call assert_fails('suspend', 'E145:') call assert_fails('call system("ls")', 'E145:') call assert_fails('call systemlist("ls")', 'E145:') if has('unix') call assert_fails('cd `pwd`', 'E145:') endif call writefile(v:errors, 'Xresult') qa! END call writefile(lines, 'Xrestricted', 'D') if RunVim([], [], '-Z --clean -S Xrestricted') call assert_equal([], readfile('Xresult')) endif call delete('Xresult') if has('unix') && RunVimPiped([], [], '--clean -S Xrestricted', 'SHELL=/bin/false ') call assert_equal([], readfile('Xresult')) endif call delete('Xresult') if has('unix') && RunVimPiped([], [], '--clean -S Xrestricted', 'SHELL=/sbin/nologin') call assert_equal([], readfile('Xresult')) endif call delete('Xresult') endfunc " vim: shiftwidth=2 sts=2 expandtab