Mercurial > vim
view src/testdir/test_environ.vim @ 33811:06219b3bdaf3 v9.0.2121
patch 9.0.2121: [security]: use-after-free in ex_substitute
Commit: https://github.com/vim/vim/commit/26c11c56888d01e298cd8044caf860f3c26f57bb
Author: Christian Brabandt <cb@256bit.org>
Date: Wed Nov 22 21:26:41 2023 +0100
patch 9.0.2121: [security]: use-after-free in ex_substitute
Problem: [security]: use-after-free in ex_substitute
Solution: always allocate memory
closes: #13552
A recursive :substitute command could cause a heap-use-after free in Vim
(CVE-2023-48706).
The whole reproducible test is a bit tricky, I can only reproduce this
reliably when no previous substitution command has been used yet
(which is the reason, the test needs to run as first one in the
test_substitute.vim file) and as a combination of the `:~` command
together with a :s command that contains the special substitution atom `~\=`
which will make use of a sub-replace special atom and calls a vim script
function.
There was a comment in the existing :s code, that already makes the
`sub` variable allocate memory so that a recursive :s call won't be able
to cause any issues here, so this was known as a potential problem
already. But for the current test-case that one does not work, because
the substitution does not start with `\=` but with `~\=` (and since
there does not yet exist a previous substitution atom, Vim will simply
increment the `sub` pointer (which then was not allocated dynamically)
and later one happily use a sub-replace special expression (which could
then free the `sub` var).
The following commit fixes this, by making the sub var always using
allocated memory, which also means we need to free the pointer whenever
we leave the function. Since sub is now always an allocated variable,
we also do no longer need the sub_copy variable anymore, since this one
was used to indicated when sub pointed to allocated memory (and had
therefore to be freed on exit) and when not.
Github Security Advisory:
https://github.com/vim/vim/security/advisories/GHSA-c8qm-x72m-q53q
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 22 Nov 2023 22:15:05 +0100 |
parents | e3ab1d0f2ef9 |
children |
line wrap: on
line source
" Test for environment variables. scriptencoding utf-8 source check.vim func Test_environ() unlet! $TESTENV call assert_equal(0, has_key(environ(), 'TESTENV')) let $TESTENV = 'foo' call assert_equal(1, has_key(environ(), 'TESTENV')) let $TESTENV = 'こんにちわ' call assert_equal('こんにちわ', environ()['TESTENV']) endfunc func Test_getenv() unlet! $TESTENV call assert_equal(v:null, 'TESTENV'->getenv()) let $TESTENV = 'foo' call assert_equal('foo', getenv('TESTENV')) endfunc func Test_setenv() unlet! $TESTENV eval 'foo'->setenv('TEST ENV') call assert_equal('foo', getenv('TEST ENV')) call setenv('TEST ENV', v:null) call assert_equal(v:null, getenv('TEST ENV')) endfunc func Test_special_env() " The value for $HOME is cached internally by Vim, ensure the value is up to " date. let orig_ENV = $HOME let $HOME = 'foo' call assert_equal('foo', expand('~')) " old $HOME value is kept until a new one is set unlet $HOME call assert_equal('foo', expand('~')) call setenv('HOME', 'bar') call assert_equal('bar', expand('~')) " old $HOME value is kept until a new one is set call setenv('HOME', v:null) call assert_equal('bar', expand('~')) let $HOME = orig_ENV endfunc func Test_external_env() call setenv('FOO', 'HelloWorld') if has('win32') let result = system('echo %FOO%') else let result = system('echo $FOO') endif let result = substitute(result, '[ \r\n]', '', 'g') call assert_equal('HelloWorld', result) call setenv('FOO', v:null) if has('win32') let result = system('set | findstr "^FOO="') else let result = system('env | grep ^FOO=') endif call assert_equal('', result) endfunc func Test_mac_locale() CheckFeature osxdarwin " If $LANG is not set then the system locale will be used. " Run Vim after unsetting all the locale environmental vars, and capture the " output of :lang. let lang_results = system("unset LANG; unset LC_MESSAGES; unset LC_CTYPE; " .. \ shellescape(v:progpath) .. \ " --clean -esX -c 'redir @a' -c 'lang' -c 'put a' -c 'print' -c 'qa!' ") " Check that: " 1. The locale is the form of <locale>.UTF-8. " 2. Check that fourth item (LC_NUMERIC) is properly set to "C". " Example match: "en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8" call assert_match('"\([a-zA-Z_]\+\.UTF-8/\)\{3}C\(/[a-zA-Z_]\+\.UTF-8\)\{2}"', \ lang_results, \ "Default locale should have UTF-8 encoding set, and LC_NUMERIC set to 'C'") endfunc " vim: shiftwidth=2 sts=2 expandtab