Mercurial > vim
view src/testdir/test_scriptnames.vim @ 33674:021e5bb88513 v9.0.2074
patch 9.0.2074: Completion menu may be wrong
Commit: https://github.com/vim/vim/commit/daef8c74375141974d61b85199b383017644978c
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Oct 27 19:16:26 2023 +0200
patch 9.0.2074: Completion menu may be wrong
Problem: Completion menu may be wrong
Solution: Check for the original direction of the completion menu,
add more tests, make it work with 'noselect'
completion: move in right direction when filling completion_info()
When moving through the insert completion menu and switching directions,
we need to make sure we start at the correct position in the list and
move correctly forward/backwards through it, so that we do not skip
entries and the selected item points to the correct entry in the list
of completion entries generated by the completion_info() function.
The general case is this:
1) CTRL-X CTRL-N, we will traverse the list starting from
compl_first_match and then go forwards (using the cp->next pointer)
through the list (skipping the very first entry, which has the
CP_ORIGINAL_TEXT flag set (since that is the empty/non-selected entry
2) CTRL-X CTRL-P, we will traverse the list starting from
compl_first_match (which now points to the last entry). The previous
entry will have the CP_ORIGINAL_TEXT flag set, so we need to start
traversing the list from the second prev pointer.
There are in fact 2 special cases after starting the completion menu
with CTRL-X:
3) CTRL-N and then going backwards by pressing CTRL-P again.
compl_first_match will point to the same entry as in step 1 above,
but since compl_dir_foward() has been switched by pressing CTRL-P
to backwards we need to pretend to be in still in case 1 and still
traverse the list in forward direction using the cp_next pointer
4) CTRL-P and then going forwards by pressing CTRL-N again.
compl_first_match will point to the same entry as in step 2 above,
but since compl_dir_foward() has been switched by pressing CTRL-N
to forwards we need to pretend to be in still in case 2 and still
traverse the list in backward direction using the cp_prev pointer
For the 'noselect' case however, this is slightly different again. When
going backwards, we only need to go one cp_prev pointer back. And
resting of the direction works again slightly different. So we need to
take the noselect option into account when deciding in which direction
to iterate through the list of matches.
related: #13402
related: #12971
closes: #13408
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 27 Oct 2023 19:30:05 +0200 |
parents | 730eebd56f48 |
children |
line wrap: on
line source
" Test for the :scriptnames command func Test_scriptnames() call writefile(['let did_load_script = 123'], 'Xscripting', 'D') source Xscripting call assert_equal(123, g:did_load_script) let scripts = split(execute('scriptnames'), "\n") let last = scripts[-1] call assert_match('\<Xscripting\>', last) let lastnr = substitute(last, '\D*\(\d\+\):.*', '\1', '') exe 'script ' . lastnr call assert_equal('Xscripting', expand('%:t')) call assert_fails('script ' . (lastnr + 1), 'E474:') call assert_fails('script 0', 'E939:') new call setline(1, 'nothing') call assert_fails('script ' . lastnr, 'E37:') exe 'script! ' . lastnr call assert_equal('Xscripting', expand('%:t')) bwipe let msgs = execute('messages') scriptnames call assert_equal(msgs, execute('messages')) endfunc " Test for the getscriptinfo() function func Test_getscriptinfo() let lines =<< trim END scriptversion 3 let g:loaded_script_id = expand("<SID>") let s:XscriptVar = [1, #{v: 2}] func s:XgetScriptVar() return s:XscriptVar endfunc func s:Xscript_legacy_func1() endfunc def s:Xscript_def_func1() enddef func Xscript_legacy_func2() endfunc def Xscript_def_func2() enddef END call writefile(lines, 'X22script91', 'D') source X22script91 let l = getscriptinfo() call assert_match('X22script91$', l[-1].name) call assert_equal(g:loaded_script_id, $"<SNR>{l[-1].sid}_") call assert_equal(3, l[-1].version) call assert_equal(0, has_key(l[-1], 'variables')) call assert_equal(0, has_key(l[-1], 'functions')) " Get script information using script name let l = getscriptinfo(#{name: '22script91'}) call assert_equal(1, len(l)) call assert_match('22script91$', l[0].name) let sid = l[0].sid " Get script information using script-ID let l = getscriptinfo({'sid': sid}) call assert_equal(#{XscriptVar: [1, {'v': 2}]}, l[0].variables) let funcs = ['Xscript_legacy_func2', \ $"<SNR>{sid}_Xscript_legacy_func1", \ $"<SNR>{sid}_Xscript_def_func1", \ 'Xscript_def_func2', \ $"<SNR>{sid}_XgetScriptVar"] for f in funcs call assert_true(index(l[0].functions, f) != -1) endfor " Verify that a script-local variable cannot be modified using the dict " returned by getscriptinfo() let l[0].variables.XscriptVar = ['n'] let funcname = $"<SNR>{sid}_XgetScriptVar" call assert_equal([1, {'v': 2}], call(funcname, [])) let l = getscriptinfo({'name': 'foobar'}) call assert_equal(0, len(l)) let l = getscriptinfo({'name': ''}) call assert_true(len(l) > 1) call assert_fails("echo getscriptinfo({'name': []})", 'E730:') call assert_fails("echo getscriptinfo({'name': '\\@'})", 'E866:') let l = getscriptinfo({'name': test_null_string()}) call assert_true(len(l) > 1) call assert_fails("echo getscriptinfo('foobar')", 'E1206:') call assert_fails("echo getscriptinfo({'sid': []})", 'E745:') call assert_fails("echo getscriptinfo({'sid': {}})", 'E728:') call assert_fails("echo getscriptinfo({'sid': 0})", 'E475:') call assert_fails("echo getscriptinfo({'sid': -1})", 'E475:') call assert_fails("echo getscriptinfo({'sid': -999})", 'E475:') echo getscriptinfo({'sid': '1'}) call assert_fails("vim9cmd echo getscriptinfo({'sid': '1'})", 'E1030:') let max_sid = max(map(getscriptinfo(), { k, v -> v.sid })) call assert_equal([], getscriptinfo({'sid': max_sid + 1})) endfunc " vim: shiftwidth=2 sts=2 expandtab