Mercurial > vim
view .cirrus.yml @ 33393:016d8f863230 v9.0.1955
patch 9.0.1955: Vim9: lockvar issues with objects/classes
Commit: https://github.com/vim/vim/commit/ee865f37acab6cac2cee6a171d60e1b365f852b0
Author: Ernie Rael <errael@raelity.com>
Date: Fri Sep 29 19:53:55 2023 +0200
patch 9.0.1955: Vim9: lockvar issues with objects/classes
Problem: Vim9: lockvar issues with objects/classes
Solution: fix `get_lhs()` object/class access and avoid `SEGV`,
make error messages more accurate.
- `get_lval()` detects/returns object/class access
- `compile_lock_unlock()` generate code for bare static and obj_arg access
- `do_lock_var()` check lval for `ll_object`/`ll_class` and fail if so.
Details:
- Add `ll_object`/`ll_class`/`ll_oi` to `lval_T`.
- Add `lockunlock_T` to `isn_T` for `is_arg` to specify handling of `lval_root` in `get_lval()`.
- In `get_lval()`, fill in `ll_object`/`ll_class`/`ll_oi` as needed; when no `[idx] or .key`, check lval_root on the way out.
- In `do_lock_var()` check for `ll_object`/`ll_class`; also bullet proof ll_dict case
and give `Dictionay required` if problem. (not needed to avoid lockvar crash anymore)
- In `compile_lock_unlock()` compile for the class variable and func arg cases.
closes: #13174
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Ernie Rael <errael@raelity.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 29 Sep 2023 20:00:07 +0200 |
parents | 42b89193ab3e |
children | 4cffda5da6f4 |
line wrap: on
line source
#env: # CIRRUS_CLONE_DEPTH: 3 # FEATURES: huge # #freebsd_task: # name: FreeBSD # matrix: # - name: FreeBSD 14.0 # freebsd_instance: # image_family: freebsd-14-0 # timeout_in: 20m # install_script: # - pkg install -y gettext # build_script: # - NPROC=$(getconf _NPROCESSORS_ONLN) # - ./configure --with-features=${FEATURES} # - make -j${NPROC} # test_script: # - src/vim --version # # run tests as user "cirrus" instead of root # - pw useradd cirrus -m # - chown -R cirrus:cirrus . # - sudo -u cirrus make test