Mercurial > vim

diff src/sign.c @ 26434:f612c41cfd94 v8.2.3748

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 8.2.3748: giving an error for an empty sign argument breaks a plugin Commit: https://github.com/vim/vim/commit/e5710a02cb78c2a0a868ea55740835c78ddecbb4 Author: Bram Moolenaar <Bram@vim.org> Date: Sun Dec 5 19:10:04 2021 +0000 patch 8.2.3748: giving an error for an empty sign argument breaks a plugin Problem: Giving an error for an empty sign argument breaks a plugin. Solution: Do not give an error.
author Bram Moolenaar <Bram@vim.org>
date Sun, 05 Dec 2021 20:15:03 +0100
parents 99a512bd8423
children 84d60deb8f82
line wrap: on
line diff
--- a/src/sign.c
+++ b/src/sign.c
@@ -1310,17 +1310,6 @@ sign_jump(int sign_id, char_u *sign_grou
     return lnum;
 }
 
-    static int
-check_empty_group(size_t len, char *name)
-{
-    if (len == 0)
-    {
-	semsg(_(e_group_name_missing_for_str), name);
-	return FAIL;
-    }
-    return OK;
-}
-
 /*
  * ":sign define {name} ..." command
  */
@@ -1335,10 +1324,6 @@ sign_define_cmd(char_u *sign_name, char_
     char_u	*texthl = NULL;
     char_u	*culhl = NULL;
     int		failed = FALSE;
-    sign_T	*sp_prev;
-    int		exists;
-
-    exists = sign_find(sign_name, &sp_prev) != NULL;
 
     // set values for a defined sign.
     for (;;)
@@ -1360,31 +1345,16 @@ sign_define_cmd(char_u *sign_name, char_
 	else if (STRNCMP(arg, "linehl=", 7) == 0)
 	{
 	    arg += 7;
-	    if (!exists && check_empty_group(p - arg, "linehl") == FAIL)
-	    {
-		failed = TRUE;
-		break;
-	    }
 	    linehl = vim_strnsave(arg, p - arg);
 	}
 	else if (STRNCMP(arg, "texthl=", 7) == 0)
 	{
 	    arg += 7;
-	    if (!exists && check_empty_group(p - arg, "texthl") == FAIL)
-	    {
-		failed = TRUE;
-		break;
-	    }
 	    texthl = vim_strnsave(arg, p - arg);
 	}
 	else if (STRNCMP(arg, "culhl=", 6) == 0)
 	{
 	    arg += 6;
-	    if (!exists && check_empty_group(p - arg, "culhl") == FAIL)
-	    {
-		failed = TRUE;
-		break;
-	    }
 	    culhl = vim_strnsave(arg, p - arg);
 	}
 	else