Mercurial > vim

diff src/evalwindow.c @ 19732:e292acf16e26 v8.2.0422

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 8.2.0422: crash when passing popup window to win_splitmove() Commit: https://github.com/vim/vim/commit/0f1563ffee4397f5b379517c41b7c9a977fd2e22 Author: Bram Moolenaar <Bram@vim.org> Date: Fri Mar 20 21:15:51 2020 +0100 patch 8.2.0422: crash when passing popup window to win_splitmove() Problem: Crash when passing popup window to win_splitmove(). (john Devin) Solution: Disallow moving a popup window. (closes https://github.com/vim/vim/issues/5816)
author Bram Moolenaar <Bram@vim.org>
date Fri, 20 Mar 2020 21:30:03 +0100
parents f0033a10b613
children 435726a03481
line wrap: on
line diff
--- a/src/evalwindow.c
+++ b/src/evalwindow.c
@@ -810,7 +810,8 @@ f_win_splitmove(typval_T *argvars, typva
     targetwin = find_win_by_nr_or_id(&argvars[1]);
 
     if (wp == NULL || targetwin == NULL || wp == targetwin
-	    || !win_valid(wp) || !win_valid(targetwin))
+	    || !win_valid(wp) || !win_valid(targetwin)
+	    || win_valid_popup(wp) || win_valid_popup(targetwin))
     {
         emsg(_(e_invalwindow));
 	rettv->vval.v_number = -1;