diff src/textprop.c @ 19601:67f39cb0a49c v8.2.0357

patch 8.2.0357: cannot delete a text property matching both id and type Commit: https://github.com/vim/vim/commit/49b79bd4888341d527c95f2aa73ed953203ce2b6 Author: Bram Moolenaar <Bram@vim.org> Date: Thu Mar 5 21:52:55 2020 +0100 patch 8.2.0357: cannot delete a text property matching both id and type Problem: Cannot delete a text property matching both id and type. (Axel Forsman) Solution: Add the "both" argument.
author Bram Moolenaar <Bram@vim.org>
date Thu, 05 Mar 2020 22:00:04 +0100
parents 36ec10251b2b
children 1d493fce1fbd
line wrap: on
line diff
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -796,6 +796,7 @@ f_prop_remove(typval_T *argvars, typval_
     int		do_all = FALSE;
     int		id = -1;
     int		type_id = -1;
+    int		both = FALSE;
 
     rettv->vval.v_number = 0;
     if (argvars[0].v_type != VAR_DICT || argvars[0].vval.v_dict == NULL)
@@ -838,11 +839,18 @@ f_prop_remove(typval_T *argvars, typval_
 	    return;
 	type_id = type->pt_id;
     }
+    if (dict_find(dict, (char_u *)"both", -1) != NULL)
+	both = dict_get_number(dict, (char_u *)"both");
     if (id == -1 && type_id == -1)
     {
 	emsg(_("E968: Need at least one of 'id' or 'type'"));
 	return;
     }
+    if (both && (id == -1 || type_id == -1))
+    {
+	emsg(_("E860: Need 'id' and 'type' with 'both'"));
+	return;
+    }
 
     if (end == 0)
 	end = buf->b_ml.ml_line_count;
@@ -868,7 +876,8 @@ f_prop_remove(typval_T *argvars, typval_
 		size_t	taillen;
 
 		mch_memmove(&textprop, cur_prop, sizeof(textprop_T));
-		if (textprop.tp_id == id || textprop.tp_type == type_id)
+		if (both ? textprop.tp_id == id && textprop.tp_type == type_id
+			 : textprop.tp_id == id || textprop.tp_type == type_id)
 		{
 		    if (!(buf->b_ml.ml_flags & ML_LINE_DIRTY))
 		    {