Mercurial > vim
diff src/testdir/test_vim9_class.vim @ 33381:17301c641749 v9.0.1949
patch 9.0.1949: Vim9: allows reserved keywords as members
Commit: https://github.com/vim/vim/commit/f057aca1cc2480e820b3ca5d8d407e3976369777
Author: Yegappan Lakshmanan <yegappan@yahoo.com>
Date: Thu Sep 28 22:28:15 2023 +0200
patch 9.0.1949: Vim9: allows reserved keywords as members
Problem: Vim9: allows reserved keywords as members
Solution: Disallow reserved keywords, disallow
duplicate object and class variables
closes: #13209
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Sep 2023 22:45:04 +0200 |
parents | 7c9124711f99 |
children | b5ad84fdc702 |
line wrap: on
line diff
--- a/src/testdir/test_vim9_class.vim +++ b/src/testdir/test_vim9_class.vim @@ -4150,7 +4150,7 @@ def Test_dup_member_variable() assert_equal(10, C.val) assert_equal(20, c.val) END - v9.CheckSourceSuccess(lines) + v9.CheckSourceFailure(lines, 'E1369: Duplicate variable: val', 4) # Duplicate object member variable in a derived class lines =<< trim END @@ -5768,4 +5768,91 @@ def Test_freed_object_from_previous_meth v9.CheckSourceSuccess(lines) enddef +" Test for duplicate object and class variable +def Test_duplicate_variable() + # Object variable name is same as the class variable name + var lines =<< trim END + vim9script + class A + public static sval: number + public this.sval: number + endclass + var a = A.new() + END + v9.CheckSourceFailure(lines, 'E1369: Duplicate variable: sval', 4) + + # Duplicate variable name and calling a class method + lines =<< trim END + vim9script + class A + public static sval: number + public this.sval: number + def F1() + echo this.sval + enddef + static def F2() + echo sval + enddef + endclass + A.F2() + END + v9.CheckSourceFailure(lines, 'E1369: Duplicate variable: sval', 4) + + # Duplicate variable with an empty constructor + lines =<< trim END + vim9script + class A + public static sval: number + public this.sval: number + def new() + enddef + endclass + var a = A.new() + END + v9.CheckSourceFailure(lines, 'E1369: Duplicate variable: sval', 4) +enddef + +" Test for using a reserved keyword as a variable name +def Test_reserved_varname() + for kword in ['true', 'false', 'null', 'null_blob', 'null_dict', + 'null_function', 'null_list', 'null_partial', 'null_string', + 'null_channel', 'null_job', 'super', 'this'] + + var lines =<< trim eval END + vim9script + class C + public this.{kword}: list<number> = [1, 2, 3] + endclass + var o = C.new() + END + v9.CheckSourceFailure(lines, $'E1034: Cannot use reserved name {kword}', 3) + + lines =<< trim eval END + vim9script + class C + public this.{kword}: list<number> = [1, 2, 3] + def new() + enddef + endclass + var o = C.new() + END + v9.CheckSourceFailure(lines, $'E1034: Cannot use reserved name {kword}', 3) + + lines =<< trim eval END + vim9script + class C + public this.{kword}: list<number> = [1, 2, 3] + def new() + enddef + def F() + echo this.{kword} + enddef + endclass + var o = C.new() + o.F() + END + v9.CheckSourceFailure(lines, $'E1034: Cannot use reserved name {kword}', 3) + endfor +enddef + " vim: ts=8 sw=2 sts=2 expandtab tw=80 fdm=marker