comparison src/ex_cmds.h @ 34320:9d07f1036a69 v9.1.0094

patch 9.1.0094: xxd: buffer-overflow when writing color output Commit: https://github.com/vim/vim/commit/00221487731ea1868c57259c7aa0eb713cd7ade7 Author: Goffredo Baroncelli <kreijack@inwind.it> Date: Sat Feb 10 13:31:06 2024 +0100 patch 9.1.0094: xxd: buffer-overflow when writing color output Problem: xxd: buffer-overflow when writing color output Solution: properly account for the color escape sequences and adjust LLEN macro (Goffredo Baroncelli) xxd: crash with higer number of column xxd writes the data into a buffer before printing. Unfortunately the buffer doesn't consider the space consumed by the escape sequences used to change the color of the character. BEFORE: $ xxd -Ralways -c 256 /etc/passwd Segmentation fault (core dumped) AFTER: $ ./xxd -Ralways -c 256 /etc/passwd 00000000: 726f 6f74 3a78 3a30 3a30 3a72 6f6f 743a 2f72 [...] To solve this issue I had to increase the size of the buffer considering for each byte of data 11 further characters for the color escape sequence. closes: #14003 Signed-off-by: Goffredo Baroncelli <kreijack@libero.it> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Sat, 10 Feb 2024 13:45:03 +0100
parents 7c30841c60a0
children dd8f5311cee5
comparison
equal deleted inserted replaced
34319:68fa6b277859 34320:9d07f1036a69