Mercurial > vim

comparison src/testdir/test_modeline.vim @ 16728:e55c26aaf484 v8.1.1366

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 8.1.1366: using expressions in a modeline is unsafe commit https://github.com/vim/vim/commit/110289e78195b6d01e1e6ad26ad450de476d41c1 Author: Bram Moolenaar <Bram@vim.org> Date: Thu May 23 15:38:06 2019 +0200 patch 8.1.1366: using expressions in a modeline is unsafe Problem: Using expressions in a modeline is unsafe. Solution: Disallow using expressions in a modeline, unless the 'modelineexpr' option is set. Update help, add more tests.
author Bram Moolenaar <Bram@vim.org>
date Thu, 23 May 2019 15:45:06 +0200
parents e52034f8b457
children 000350f8e4d1
comparison
equal deleted inserted replaced
16727:8be69877c5de 16728:e55c26aaf484
58 call delete('Xmodeline_keymap') 58 call delete('Xmodeline_keymap')
59 let &modeline = modeline 59 let &modeline = modeline
60 set keymap= iminsert=0 imsearch=-1 60 set keymap= iminsert=0 imsearch=-1
61 endfunc 61 endfunc
62 62
63 func s:modeline_fails(what, text) 63 func s:modeline_fails(what, text, error)
64 if !exists('+' .. a:what)
65 return
66 endif
64 let fname = "Xmodeline_fails_" . a:what 67 let fname = "Xmodeline_fails_" . a:what
65 call writefile(['vim: set ' . a:text . ' :', 'nothing'], fname) 68 call writefile(['vim: set ' . a:text . ' :', 'nothing'], fname)
66 let modeline = &modeline 69 let modeline = &modeline
67 set modeline 70 set modeline
68 filetype plugin on 71 filetype plugin on
69 syntax enable 72 syntax enable
70 call assert_fails('split ' . fname, 'E474:') 73 call assert_fails('split ' . fname, a:error)
71 call assert_equal("", &filetype) 74 call assert_equal("", &filetype)
72 call assert_equal("", &syntax) 75 call assert_equal("", &syntax)
73 76
74 bwipe! 77 bwipe!
75 call delete(fname) 78 call delete(fname)
77 filetype plugin off 80 filetype plugin off
78 syntax off 81 syntax off
79 endfunc 82 endfunc
80 83
81 func Test_modeline_filetype_fails() 84 func Test_modeline_filetype_fails()
82 call s:modeline_fails('filetype', 'ft=evil$CMD') 85 call s:modeline_fails('filetype', 'ft=evil$CMD', 'E474:')
83 endfunc 86 endfunc
84 87
85 func Test_modeline_syntax_fails() 88 func Test_modeline_syntax_fails()
86 call s:modeline_fails('syntax', 'syn=evil$CMD') 89 call s:modeline_fails('syntax', 'syn=evil$CMD', 'E474:')
87 endfunc 90 endfunc
88 91
89 func Test_modeline_keymap_fails() 92 func Test_modeline_keymap_fails()
90 if !has('keymap') 93 call s:modeline_fails('keymap', 'keymap=evil$CMD', 'E474:')
91 return
92 endif
93 call s:modeline_fails('keymap', 'keymap=evil$CMD')
94 endfunc 94 endfunc
95
96 func Test_modeline_fails_always()
97 call s:modeline_fails('backupdir', 'backupdir=Something()', 'E520:')
98 call s:modeline_fails('cdpath', 'cdpath=Something()', 'E520:')
99 call s:modeline_fails('charconvert', 'charconvert=Something()', 'E520:')
100 call s:modeline_fails('completefunc', 'completefunc=Something()', 'E520:')
101 call s:modeline_fails('cscopeprg', 'cscopeprg=Something()', 'E520:')
102 call s:modeline_fails('diffexpr', 'diffexpr=Something()', 'E520:')
103 call s:modeline_fails('directory', 'directory=Something()', 'E520:')
104 call s:modeline_fails('equalprg', 'equalprg=Something()', 'E520:')
105 call s:modeline_fails('errorfile', 'errorfile=Something()', 'E520:')
106 call s:modeline_fails('exrc', 'exrc=Something()', 'E520:')
107 call s:modeline_fails('formatprg', 'formatprg=Something()', 'E520:')
108 call s:modeline_fails('fsync', 'fsync=Something()', 'E520:')
109 call s:modeline_fails('grepprg', 'grepprg=Something()', 'E520:')
110 call s:modeline_fails('helpfile', 'helpfile=Something()', 'E520:')
111 call s:modeline_fails('imactivatefunc', 'imactivatefunc=Something()', 'E520:')
112 call s:modeline_fails('imstatusfunc', 'imstatusfunc=Something()', 'E520:')
113 call s:modeline_fails('imstyle', 'imstyle=Something()', 'E520:')
114 call s:modeline_fails('keywordprg', 'keywordprg=Something()', 'E520:')
115 call s:modeline_fails('langmap', 'langmap=Something()', 'E520:')
116 call s:modeline_fails('luadll', 'luadll=Something()', 'E520:')
117 call s:modeline_fails('makeef', 'makeef=Something()', 'E520:')
118 call s:modeline_fails('makeprg', 'makeprg=Something()', 'E520:')
119 call s:modeline_fails('makespellmem', 'makespellmem=Something()', 'E520:')
120 call s:modeline_fails('mzschemedll', 'mzschemedll=Something()', 'E520:')
121 call s:modeline_fails('mzschemegcdll', 'mzschemegcdll=Something()', 'E520:')
122 call s:modeline_fails('omnifunc', 'omnifunc=Something()', 'E520:')
123 call s:modeline_fails('operatorfunc', 'operatorfunc=Something()', 'E520:')
124 call s:modeline_fails('perldll', 'perldll=Something()', 'E520:')
125 call s:modeline_fails('printdevice', 'printdevice=Something()', 'E520:')
126 call s:modeline_fails('patchexpr', 'patchexpr=Something()', 'E520:')
127 call s:modeline_fails('printexpr', 'printexpr=Something()', 'E520:')
128 call s:modeline_fails('pythondll', 'pythondll=Something()', 'E520:')
129 call s:modeline_fails('pythonhome', 'pythondll=Something()', 'E520:')
130 call s:modeline_fails('pythonthreedll', 'pythonthreedll=Something()', 'E520:')
131 call s:modeline_fails('pythonthreehome', 'pythonthreehome=Something()', 'E520:')
132 call s:modeline_fails('pyxversion', 'pyxversion=Something()', 'E520:')
133 call s:modeline_fails('rubydll', 'rubydll=Something()', 'E520:')
134 call s:modeline_fails('runtimepath', 'runtimepath=Something()', 'E520:')
135 call s:modeline_fails('secure', 'secure=Something()', 'E520:')
136 call s:modeline_fails('shell', 'shell=Something()', 'E520:')
137 call s:modeline_fails('shellcmdflag', 'shellcmdflag=Something()', 'E520:')
138 call s:modeline_fails('shellpipe', 'shellpipe=Something()', 'E520:')
139 call s:modeline_fails('shellquote', 'shellquote=Something()', 'E520:')
140 call s:modeline_fails('shellredir', 'shellredir=Something()', 'E520:')
141 call s:modeline_fails('shellxquote', 'shellxquote=Something()', 'E520:')
142 call s:modeline_fails('spellfile', 'spellfile=Something()', 'E520:')
143 call s:modeline_fails('spellsuggest', 'spellsuggest=Something()', 'E520:')
144 call s:modeline_fails('tcldll', 'tcldll=Something()', 'E520:')
145 call s:modeline_fails('titleold', 'titleold=Something()', 'E520:')
146 call s:modeline_fails('viewdir', 'viewdir=Something()', 'E520:')
147 call s:modeline_fails('viminfo', 'viminfo=Something()', 'E520:')
148 call s:modeline_fails('viminfofile', 'viminfofile=Something()', 'E520:')
149 call s:modeline_fails('winptydll', 'winptydll=Something()', 'E520:')
150 call s:modeline_fails('undodir', 'undodir=Something()', 'E520:')
151 " only check a few terminal options
152 call s:modeline_fails('t_AB', 't_AB=Something()', 'E520:')
153 call s:modeline_fails('t_ce', 't_ce=Something()', 'E520:')
154 call s:modeline_fails('t_sr', 't_sr=Something()', 'E520:')
155 call s:modeline_fails('t_8b', 't_8b=Something()', 'E520:')
156 endfunc
157
158 func Test_modeline_fails_modelineexpr()
159 call s:modeline_fails('balloonexpr', 'balloonexpr=Something()', 'E992:')
160 call s:modeline_fails('foldexpr', 'foldexpr=Something()', 'E992:')
161 call s:modeline_fails('foldtext', 'foldtext=Something()', 'E992:')
162 call s:modeline_fails('formatexpr', 'formatexpr=Something()', 'E992:')
163 call s:modeline_fails('guitablabel', 'guitablabel=Something()', 'E992:')
164 call s:modeline_fails('iconstring', 'iconstring=Something()', 'E992:')
165 call s:modeline_fails('includeexpr', 'includeexpr=Something()', 'E992:')
166 call s:modeline_fails('indentexpr', 'indentexpr=Something()', 'E992:')
167 call s:modeline_fails('rulerformat', 'rulerformat=Something()', 'E992:')
168 call s:modeline_fails('statusline', 'statusline=Something()', 'E992:')
169 call s:modeline_fails('tabline', 'tabline=Something()', 'E992:')
170 call s:modeline_fails('titlestring', 'titlestring=Something()', 'E992:')
171 endfunc