comparison src/popupwin.c @ 17075:dacd46fbaa90 v8.1.1537

patch 8.1.1537: using "tab" for popup window can be confusing commit https://github.com/vim/vim/commit/fc06cbbf8601a453b4a62a17558821add09f863f Author: Bram Moolenaar <Bram@vim.org> Date: Sat Jun 15 14:14:31 2019 +0200 patch 8.1.1537: using "tab" for popup window can be confusing Problem: Using "tab" for popup window can be confusing. Solution: Use "tabpage". (Hirohito Higashi, closes https://github.com/vim/vim/issues/4532)
author Bram Moolenaar <Bram@vim.org>
date Sat, 15 Jun 2019 14:15:06 +0200
parents 294b409ce7e3
children 2546930657a9
comparison
equal deleted inserted replaced
17074:a86c4ae3192a 17075:dacd46fbaa90
746 wp->w_p_wrap = TRUE; // 'wrap' is default on 746 wp->w_p_wrap = TRUE; // 'wrap' is default on
747 747
748 // Avoid that 'buftype' is reset when this buffer is entered. 748 // Avoid that 'buftype' is reset when this buffer is entered.
749 buf->b_p_initialized = TRUE; 749 buf->b_p_initialized = TRUE;
750 750
751 if (dict_find(d, (char_u *)"tab", -1) != NULL) 751 if (dict_find(d, (char_u *)"tabpage", -1) != NULL)
752 nr = (int)dict_get_number(d, (char_u *)"tab"); 752 nr = (int)dict_get_number(d, (char_u *)"tabpage");
753 else if (type == TYPE_NOTIFICATION) 753 else if (type == TYPE_NOTIFICATION)
754 nr = -1; // notifications are global by default 754 nr = -1; // notifications are global by default
755 else 755 else
756 nr = 0; 756 nr = 0;
757 757
758 if (nr == 0) 758 if (nr == 0)
759 { 759 {
760 // popup on current tab 760 // popup on current tab page
761 wp->w_next = curtab->tp_first_popupwin; 761 wp->w_next = curtab->tp_first_popupwin;
762 curtab->tp_first_popupwin = wp; 762 curtab->tp_first_popupwin = wp;
763 } 763 }
764 else if (nr < 0) 764 else if (nr < 0)
765 { 765 {
1226 return FALSE; 1226 return FALSE;
1227 } 1227 }
1228 1228
1229 /* 1229 /*
1230 * Reset all the POPF_HANDLED flags in global popup windows and popup windows 1230 * Reset all the POPF_HANDLED flags in global popup windows and popup windows
1231 * in the current tab. 1231 * in the current tab page.
1232 */ 1232 */
1233 void 1233 void
1234 popup_reset_handled() 1234 popup_reset_handled()
1235 { 1235 {
1236 win_T *wp; 1236 win_T *wp;