Mercurial > vim
comparison src/version.c @ 33660:ca0229869b38 v9.0.2068
patch 9.0.2068: [security] overflow in :history
Commit: https://github.com/vim/vim/commit/9198c1f2b1ddecde22af918541e0de2a32f0f45a
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 21:29:32 2023 +0200
patch 9.0.2068: [security] overflow in :history
Problem: [security] overflow in :history
Solution: Check that value fits into int
The get_list_range() function, used to parse numbers for the :history
and :clist command internally uses long variables to store the numbers.
However function arguments are integer pointers, which can then
overflow.
Check that the return value from the vim_str2nr() function is not larger
than INT_MAX and if yes, bail out with an error. I guess nobody uses a
cmdline/clist history that needs so many entries... (famous last words).
It is only a moderate vulnerability, so impact should be low.
Github Advisory:
https://github.com/vim/vim/security/advisories/GHSA-q22m-h7m2-9mgm
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 21:45:05 +0200 |
parents | 38b0ea4d17cc |
children | 664ee4c0daca |
comparison
equal
deleted
inserted
replaced
33659:867fa40377c1 | 33660:ca0229869b38 |
---|---|
702 NULL | 702 NULL |
703 }; | 703 }; |
704 | 704 |
705 static int included_patches[] = | 705 static int included_patches[] = |
706 { /* Add new patch number below this line */ | 706 { /* Add new patch number below this line */ |
707 /**/ | |
708 2068, | |
707 /**/ | 709 /**/ |
708 2067, | 710 2067, |
709 /**/ | 711 /**/ |
710 2066, | 712 2066, |
711 /**/ | 713 /**/ |