comparison src/testdir/test_crash.vim @ 33915:a49ae967e9ed v9.0.2158

patch 9.0.2158: [security]: use-after-free in check_argument_type Commit: https://github.com/vim/vim/commit/0f28791b215bd4c22ed580839409c2f7d39d8140 Author: Christian Brabandt <cb@256bit.org> Date: Mon Dec 11 17:53:25 2023 +0100 patch 9.0.2158: [security]: use-after-free in check_argument_type Problem: [security]: use-after-free in check_argument_type Solution: Reset function type pointer when freeing the function type list function pointer fp->uf_func_type may point to the same memory, that was allocated for fp->uf_type_list. However, when cleaning up a function definition (e.g. because it was invalid), fp->uf_type_list will be freed, but fp->uf_func_type may still point to the same (now) invalid memory address. So when freeing the fp->uf_type_list, check if fp->func_type points to any of those types and if it does, reset the fp->uf_func_type pointer to the t_func_any (default) type pointer closes: #13652 Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Mon, 11 Dec 2023 18:00:03 +0100
parents d418c82f02a4
children 1758bb7a9865
comparison
equal deleted inserted replaced
33914:966a1af141b0 33915:a49ae967e9ed
182 let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'\<cr>" 182 let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'\<cr>"
183 let args = printf(cmn_args, vim, file) 183 let args = printf(cmn_args, vim, file)
184 call term_sendkeys(buf, args) 184 call term_sendkeys(buf, args)
185 call TermWait(buf, 150) 185 call TermWait(buf, 150)
186 186
187 let file = 'crash/poc_uaf_check_argument_types'
188 let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'\<cr>"
189 let args = printf(cmn_args, vim, file)
190 call term_sendkeys(buf, args)
191 call TermWait(buf, 150)
192
187 " clean up 193 " clean up
188 exe buf .. "bw!" 194 exe buf .. "bw!"
189 bw! 195 bw!
190 endfunc 196 endfunc
191 197